Pin versions of libraries and tools required for proto generation. #492
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change pins the versions of the libraries that were used to generate the proto definitions using dep. The Makefile is then modified so that the tool and library versions used to build the proto generated files are from the vendor directory. This is a hacky, short-term solution to ensure a reproducible build while we work on switching to bazel. The versions in the Gopkg.toml file were chosen based on my experiments that generated proto files that did not change from what is already checked in.
|
Note that running Make did not change the proto files produced at all. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vicaire The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
magdalenakuhn17
pushed a commit
to magdalenakuhn17/pipelines
that referenced
this pull request
Oct 22, 2023
* WIP: Refactoring KFServer and KFModel. * Removes concept of Seldon Protocol * Gives more context to KFModel to enable additional params in predict()/explain() * Cleaner class design for KFModel implementers with default passthrough for predict()/explain() * Fixed tests and references * Fixing up tests and mains * creating test folders * creating test folders * Moved kfserving tests into a test directory * Fixing lint errors and adding tests * Fixed json parsing * Fixed up pytorch tests * Improved performance of validation by serializing only once * fixed instances in explainer * updated version * updated version * Fixed explainer code to point to existing cat image * fixed up tests * removed bad data file * Fixed sdk tests * Fixed sdk tests * Fixed broken test * disabled some tests for now * Fixed linter issues * more linting fixes * more linter fixes * fixed server tesT * Revert sdk test changes * removed comments * linting fixes * moved tests back * Fixed up some stuff with dan * linter fixes * another pre/post fix * whitespace * Responded to review comments * removed unnecessary import:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change pins the versions of the libraries that were used to
generate the proto definitions using dep. The Makefile is then modified
so that the tool and library versions used to build the proto generated
files are from the vendor directory. This is a hacky, short-term
solution to ensure a reproducible build while we work on switching to
bazel.
The versions in the Gopkg.toml file were chosen based on my experiments
that generated proto files that did not change from what is already
checked in.
This change is