Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(components): parametrize InferenceService resource watching timeout #4951

Merged
merged 1 commit into from
Jan 8, 2021

Conversation

alembiewski
Copy link
Member

Description of your changes:
Currently, InferenceService resource watching timeout is hardcoded and there is no way to configure it. We have observed some pipeline failures in our environment when kfserving component has failed due to timing out waiting for a resource to become ready, which in our case can take more than the default timeout (120 seconds). This PR makes it configurable and retains the default functionality.

Checklist:

@k8s-ci-robot
Copy link
Contributor

Hi @alembiewski. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Tomcli
Copy link
Member

Tomcli commented Jan 5, 2021

/ok-to-test

@Tomcli
Copy link
Member

Tomcli commented Jan 6, 2021

/lgtm

@alembiewski
Copy link
Member Author

/assign @animeshsingh

@animeshsingh
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alembiewski, animeshsingh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 27fa60b into kubeflow:master Jan 8, 2021
alexeygorobets pushed a commit to d2iq-archive/pipelines that referenced this pull request Feb 18, 2021
alexeygorobets pushed a commit to d2iq-archive/pipelines that referenced this pull request Feb 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants