-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(components): parametrize InferenceService resource watching timeout #4951
Conversation
Hi @alembiewski. Thanks for your PR. I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
/lgtm |
/assign @animeshsingh |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alembiewski, animeshsingh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…timeout (kubeflow#4951) (cherry picked from commit 27fa60b)
…timeout (kubeflow#4951) (cherry picked from commit 27fa60b)
Description of your changes:
Currently,
InferenceService
resource watching timeout is hardcoded and there is no way to configure it. We have observed some pipeline failures in our environment whenkfserving
component has failed due to timing out waiting for a resource to become ready, which in our case can take more than the default timeout (120 seconds). This PR makes it configurable and retains the default functionality.Checklist:
Do you want this pull request (PR) cherry-picked into the current release branch?
Learn more about cherry-picking updates into the release branch.