feat(backend): upgrade argo library to 2.12.6. Part of #4553 #5041
Conversation
|
/hold |
NikeNano
changed the title
NikeNano
changed the title
|
/unhold |
|
/assign @paveldournov |
|
FYI @Bobgy @capri-xiyue |
|
/assign @capri-xiyue |
|
/lgtm |
|
Disturbed in the week by a bunch of things, just want to give a heads up this is one of the top priorities I will look at. |
|
@Bobgy Why can't we upgrade to Argo v3.0, RCs are already out, it has so many more features like Events apart from the features like Enhanced artifact management: Enhanced artifact repository reference and Auto-create S3 buckets. |
backend/src/common/util/workflow.go
Outdated
| @@ -51,11 +51,17 @@ func (w *Workflow) OverrideParameters(desiredParams map[string]string) { | |||
| if param, ok := desiredParams[currentParam.Name]; ok { | |||
| desiredValue = ¶m | |||
| } else { | |||
| desiredValue = currentParam.Value | |||
| val := currentParam.Value.String() | |||
There was a problem hiding this comment.
nit: the val here is a different variable than the val below, shall we use different names?
can we improve this via util.StringToPtr?
@deepk2u there were very drastic changes, so we'd want to stay in the LTS version as a step stone first to keep KFP stable. Argo maintainer also suggested us to use the LTS first, it's not hard upgrading the second time if we survived this one. |
|
Clicked Approve by mistake. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: NikeNano The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
New changes are detected. LGTM label has been removed. |
|
Would be great if you could take a look again @Bobgy? |
|
/lgtm I'll follow up on #4553, |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Bobgy, NikeNano The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Bobgy
changed the title
Bobgy
changed the title
Bobgy
changed the title
Description of your changes:
Update argo to version 2.12.6, commit 4cb5b7eb807573e167f3429fb5fc8bf5ade0685d, solves #4553
Checklist:
Do you want this pull request (PR) cherry-picked into the current release branch?
Learn more about cherry-picking updates into the release branch.