Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: update argo image to v2.12.9 and automate update process. Fixes #5232 #5266

Merged
merged 16 commits into from
Mar 10, 2021
Merged

feat: update argo image to v2.12.9 and automate update process. Fixes #5232 #5266

merged 16 commits into from
Mar 10, 2021

Conversation

Bobgy
Copy link
Contributor

@Bobgy Bobgy commented Mar 9, 2021 •
edited
Loading

Description of your changes:
Fixes #5232

Changes:

  • partially automate argo update process
  • update argo cli to latest too, because the previous blocker was resolved
  • update argo manifests for breaking changes
  • move argo manifests to third-party folder
  • presubmit test for marketplace manifest

Checklist:

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Bobgy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-cla google-cla bot added the cla: yes label Mar 9, 2021
@Bobgy
Copy link
Contributor Author

Bobgy commented Mar 9, 2021

/assign @capri-xiyue @NikeNano

@Bobgy
Copy link
Contributor Author

Bobgy commented Mar 9, 2021

/hold
/wip

I think I shouldn't add the NOTICES folder to KFP source repo. It's better provide a script that can deterministically generate them.

@Bobgy
Copy link
Contributor Author

Bobgy commented Mar 9, 2021

/test ?

@google-oss-robot
Copy link

@Bobgy: The following commands are available to trigger jobs:

  • /test kubeflow-pipeline-frontend-test
  • /test kubeflow-pipeline-backend-test
  • /test kubeflow-pipeline-e2e-test
  • /test kubeflow-pipeline-sample-test
  • /test kubeflow-pipeline-integration-test
  • /test kubeflow-pipeline-mkp-test
  • /test kubeflow-pipeline-upgrade-test
  • /test kubeflow-pipelines-sdk-python36
  • /test kubeflow-pipelines-sdk-python37
  • /test kubeflow-pipelines-sdk-python38
  • /test kubeflow-pipelines-sdk-python39
  • /test kubeflow-pipelines-tfx-python36
  • /test kubeflow-pipelines-component-yaml
  • /test kubeflow-pipelines-components-gcp-python27
  • /test kubeflow-pipelines-components-gcp-python37
  • /test kubeflow-pipelines-backend-visualization

Use /test all to run the following jobs:

  • kubeflow-pipeline-frontend-test
  • kubeflow-pipeline-backend-test
  • kubeflow-pipeline-e2e-test
  • kubeflow-pipeline-sample-test
  • kubeflow-pipeline-upgrade-test

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Bobgy
Copy link
Contributor Author

Bobgy commented Mar 9, 2021

/test kubeflow-pipelines-sdk-python36
/test kubeflow-pipelines-sdk-python37
/test kubeflow-pipelines-sdk-python38
/test kubeflow-pipelines-sdk-python39
/test kubeflow-pipelines-tfx-python36

These tests also used argo cli.

@Bobgy Bobgy mentioned this pull request Mar 9, 2021
Merged
@Bobgy Bobgy changed the title feat: update argo image to v2.12.9. Fixes #5232 feat: update argo image to v2.12.9 and automate update process. Fixes #5232 Mar 9, 2021
@Bobgy
Copy link
Contributor Author

Bobgy commented Mar 9, 2021

/retest

@chensun
Copy link
Member

chensun commented Mar 9, 2021

/lgtm

Thanks!

@Bobgy
Copy link
Contributor Author

Bobgy commented Mar 9, 2021

Looks like I need to incorporate a few more changes in #4693.

@Bobgy
Copy link
Contributor Author

Bobgy commented Mar 9, 2021

/hold
I'd suggest letting #5256 merge earlier.

NikeNano
NikeNano reviewed Mar 9, 2021
View reviewed changes
manifests/gcp_marketplace/test/snapshot-base.yaml Show resolved Hide resolved
manifests/gcp_marketplace/test/snapshot-managed-storage-with-db-prefix.yaml Show resolved Hide resolved
manifests/gcp_marketplace/test/snapshot-managed-storage.yaml Show resolved Hide resolved
manifests/kustomize/env/aws/config Show resolved Hide resolved
third_party/argo/README.md
This folder holds resources for KFP to redistribute <https://argoproj.github.io/projects/argo>
container images.

There's no code change. KFP only makes sure the images comply with licenses of all its dependencies
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is a bit unclear to me what we mean with this:

There's no code change.

Copy link
Contributor Author

@Bobgy Bobgy Mar 10, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Understood the confusion, I meant we are not modifying argo workflow code, the redistribution only adds license compliance. Do you have a suggestion of how to improve?

backend/Dockerfile Show resolved Hide resolved
@Ark-kun
Copy link
Contributor

Ark-kun commented Mar 9, 2021

/lgtm
/hold
Unhold as needed.

@google-oss-robot
Copy link

New changes are detected. LGTM label has been removed.

@Bobgy
Copy link
Contributor Author

Bobgy commented Mar 10, 2021

I'll merge when all tests pass. It's better to iterate quick because there were structural changes.

@Bobgy
Copy link
Contributor Author

Bobgy commented Mar 10, 2021

/unhold

@Bobgy Bobgy merged commit be64b32 into kubeflow:master Mar 10, 2021
@Bobgy Bobgy deleted the update-argo-2.12.9 branch March 10, 2021 04:52
@Bobgy Bobgy mentioned this pull request Mar 13, 2021
Closed
This was referenced Mar 19, 2021
Merged
Closed
@zijianjoy zijianjoy mentioned this pull request Mar 29, 2021
Merged
2 tasks
@juliusvonkohout juliusvonkohout mentioned this pull request May 21, 2021
Closed
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NikeNano NikeNano NikeNano left review comments

@Ark-kun Ark-kun Ark-kun left review comments

@capri-xiyue capri-xiyue Awaiting requested review from capri-xiyue

@dushyanthsc dushyanthsc Awaiting requested review from dushyanthsc

@gaoning777 gaoning777 Awaiting requested review from gaoning777

@numerology numerology Awaiting requested review from numerology

Assignees

@Ark-kun Ark-kun

@chensun chensun

@NikeNano NikeNano

@capri-xiyue capri-xiyue

Labels
approved cla: yes size/XXL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Upgrade argo image to 2.12+
6 participants
@Bobgy @google-oss-robot @chensun @Ark-kun @NikeNano @capri-xiyue