Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: the cache server in combination with kubeflow profile quotas #5743

Merged
merged 2 commits into from
Oct 21, 2021

Conversation

juliusvonkohout
Copy link
Member

@juliusvonkohout juliusvonkohout commented May 27, 2021

Caching is not compatible with profile quotas that specify CPU requests. #5695 is overwritten by the mutatingwebhook at

dummyContainer := corev1.Container{
Name: "main",
Image: image,
Command: []string{`echo`, `"This step output is taken from cache."`},
}

I used https://github.com/pantheon-systems/cassandra-operator/blob/735de0001e9d23ea0bf4a79c6b51f4ccbe95777d/pkg/resource/cassandra_pod.go#L90 as reference

@google-oss-robot
Copy link

Hi @juliusvonkohout. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@juliusvonkohout juliusvonkohout changed the title Fix the cache server in combination with kubeflow profile quotas WIP Fix the cache server in combination with kubeflow profile quotas May 27, 2021
@juliusvonkohout juliusvonkohout changed the title WIP Fix the cache server in combination with kubeflow profile quotas fix: the cache server in combination with kubeflow profile quotas Oct 15, 2021
@juliusvonkohout
Copy link
Member Author

@Ark-kun
@rui5i
can you take a look at this fix?

@juliusvonkohout
Copy link
Member Author

@Bobgy what do you think?

@Bobgy
Copy link
Contributor

Bobgy commented Oct 19, 2021

/cc @capri-xiyue
What do you think?

/lgtm

@capri-xiyue
Copy link
Contributor

capri-xiyue commented Oct 20, 2021

Is it possible to read the Resources requests and requirements from kubeflow profile quotas like configmap https://github.com/kubeflow/pipelines/pull/5695/files#diff-61f22a36206e85146e61ed6d59d5a0636acc9b4e95b4f97f647727a02ad20710R2?

@juliusvonkohout
Copy link
Member Author

juliusvonkohout commented Oct 21, 2021

@capri-xiyue we could mount the key "executor" of the workflow-controller-configmap as we do mount pipeline-install-config, but then we would have to parse the text and I do not see the reason for that. These two numbers are not that strongly related one is for real Argo preparation and to satisfy kubeflow profile quota restrictions, the other is just for pulling the cached value from minio an satisfying the kubeflow profile quota requirements. I can also change it to 32Mi manually for more "consistency"

@capri-xiyue
Copy link
Contributor

/lgtm
/approve

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: capri-xiyue

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

emsixteeen pushed a commit to emsixteeen/kubeflow-pipelines that referenced this pull request Aug 23, 2023
emsixteeen pushed a commit to emsixteeen/kubeflow-pipelines that referenced this pull request Sep 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants