-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: the cache server in combination with kubeflow profile quotas #5743
Conversation
Hi @juliusvonkohout. Thanks for your PR. I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
475596c
to
e10b1d2
Compare
@Bobgy what do you think? |
/cc @capri-xiyue /lgtm |
Is it possible to read the Resources requests and requirements from kubeflow profile quotas like configmap https://github.com/kubeflow/pipelines/pull/5695/files#diff-61f22a36206e85146e61ed6d59d5a0636acc9b4e95b4f97f647727a02ad20710R2? |
@capri-xiyue we could mount the key "executor" of the workflow-controller-configmap as we do mount pipeline-install-config, but then we would have to parse the text and I do not see the reason for that. These two numbers are not that strongly related one is for real Argo preparation and to satisfy kubeflow profile quota restrictions, the other is just for pulling the cached value from minio an satisfying the kubeflow profile quota requirements. I can also change it to 32Mi manually for more "consistency" |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: capri-xiyue The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…beflow#5743) * Update mutation.go * Update mutation.go
…beflow#5743) * Update mutation.go * Update mutation.go
Caching is not compatible with profile quotas that specify CPU requests. #5695 is overwritten by the mutatingwebhook at
pipelines/backend/src/cache/server/mutation.go
Lines 151 to 155 in 1db9db5
I used https://github.com/pantheon-systems/cassandra-operator/blob/735de0001e9d23ea0bf4a79c6b51f4ccbe95777d/pkg/resource/cassandra_pod.go#L90 as reference