Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(components): Addressing Review comments on Trainer component for PyTorch - KFP #5814

Conversation

ankan94
Copy link
Contributor

@ankan94 ankan94 commented Jun 8, 2021

Description of your changes:
Issue: #5768
We are working on adding support for PyTorch in Kubeflow Pipelines.

there are multiple components involved in the PyTorch pipeline.

This PR addresses the review comments on already merged PR #5767

The idea is to package all the components as pytorch-kfp-components. It will be a pip package.

The code for the pip package is placed under - pipelines/components/PyTorch/pytorch-kfp-components folder.

Users can install the pip package from this folder and use it in the examples.

We are working on adding the remaining components and the examples as separate PRs.

Please review and let us know your comments.

Checklist:

Arvind-Ideas2IT and others added 6 commits June 8, 2021 14:03
Signed-off-by: Arvind-Ideas2IT <arvindkumarsingh.gautam@ideas2it.com>
Signed-off-by: ankan94 <ankan@ideas2it.com>
Signed-off-by: ankan94 <ankan@ideas2it.com>
Signed-off-by: ankan94 <ankan@ideas2it.com>
Signed-off-by: ankan94 <ankan@ideas2it.com>
Signed-off-by: ankan94 <ankan@ideas2it.com>
@google-oss-robot
Copy link

Hi @ankan94. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@google-cla
Copy link

google-cla bot commented Jun 8, 2021

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added the cla: no label Jun 8, 2021
@ankan94
Copy link
Contributor Author

ankan94 commented Jun 8, 2021

@googlebot I consent.

@google-cla
Copy link

google-cla bot commented Jun 8, 2021

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@Arvind-Ideas2IT
Copy link
Contributor

@googlebot I consent.

@google-cla google-cla bot added cla: yes and removed cla: no labels Jun 8, 2021
@ankan94 ankan94 changed the title feat(components): Addressing Review comments on Trainer component for PyTorch - KFP [WIP]feat(components): Addressing Review comments on Trainer component for PyTorch - KFP Jun 9, 2021
@chauhang
Copy link
Contributor

/lgtm
/ok-to-test
/approve

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chauhang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ankan94 ankan94 changed the title [WIP]feat(components): Addressing Review comments on Trainer component for PyTorch - KFP feat(components): Addressing Review comments on Trainer component for PyTorch - KFP Jun 14, 2021
@chauhang
Copy link
Contributor

/lgtm
/ok-to-test
/approved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants