chore(samples/pytorch) - Build script fix - Updating Dockerfile name #5928
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Shrinath Suresh <shrinath@ideas2it.com>
shrinath-suresh
changed the title
Signed-off-by: Shrinath Suresh <shrinath@ideas2it.com>
jagadeeshi2i
approved these changes
Jun 28, 2021
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jagadeeshi2i The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
shrinath-suresh
commented
Jun 28, 2021
| @@ -4,7 +4,7 @@ metrics_address=http://0.0.0.0:8082 | |||
| enable_metrics_api=true | |||
| metrics_format=prometheus | |||
| number_of_netty_threads=4 | |||
| install_py_dep_per_model=true | |||
| install_py_dep_per_model=false | |||
There was a problem hiding this comment.
Setting it to false until Custom package installation issue is fixed in torchserve
shrinath-suresh
commented
Jun 28, 2021
| @@ -25,7 +25,7 @@ export full_image_name=$full_image_name | |||
| ## build and push docker - to fetch the latest changes and install dependencies | |||
| # cd pytorch_kfp_components | |||
|
|
|||
| docker build --no-cache -t $full_image_name -f Dockerfile-cpu . | |||
There was a problem hiding this comment.
We no longer need the dockerfile name as we have only one dockerfile now for both cpu and gpu
|
/lgtm |
|
/retest |
1 similar comment
|
/retest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#5863 - We no longer have separate dockerfile for cpu and gpu. The build script needs to be updated accordingly.
In this PR, dockerfile name has been removed from the
docker buildargument.Checklist: