chore: record artifact state & render state on resource details. Fixes #5789 #5970
Conversation
| {this.props.typeName} | ||
| {(() => { | ||
| const stateText = getResourceStateText(this.props); | ||
| if (stateText) { | ||
| return ` (${stateText})`; | ||
| } | ||
| return ''; | ||
| })()} | ||
| </h1> |
There was a problem hiding this comment.
because we didn't log state before, if we found state=Unknown, it's better not to render it
There was a problem hiding this comment.
The text change from Type: <type-name> to <type-name> (<state>) is following principle that, when text content can tell what it is, UI would feel more concise when the Type: and State: prefix is omitted.
For example, when we see kfp.ContainerExecution, we know it is a type of execution, so it's unnecessary to add prefix Type: now.
|
New changes are detected. LGTM label has been removed. |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Bobgy The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
1 similar comment
|
/retest |
|
Got error:
in output a directory sample |
|
/retest |
|
/retest |
|
New changes are detected. LGTM label has been removed. |
Description of your changes:
Fixes #5789
Checklist: