Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: allow the default-editor to edit argo workflows and fix bug #6649 #6622

Merged
merged 2 commits into from
Nov 2, 2021
Merged

feat: allow the default-editor to edit argo workflows and fix bug #6649 #6622

merged 2 commits into from
Nov 2, 2021

Conversation

juliusvonkohout
Copy link
Member

@juliusvonkohout juliusvonkohout commented Sep 27, 2021 •
edited
Loading

Description of your changes:

@elikatsis @zijianjoy
This also fixes bug #6649

@Bobgy Currently the jupyterlab user has no way to cleanup his workspace

With this change e.g.

kubectl -n $NAMESPACE delete workflows -l 'workflows.argoproj.io/completed=true' # for argo

works

Checklist:

@google-cla google-cla bot added the cla: yes label Sep 27, 2021
@google-oss-robot
Copy link

Hi @juliusvonkohout. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

This was referenced Oct 13, 2021
Closed
Closed
@juliusvonkohout
Copy link
Member Author

@zijianjoy
@Bobgy

can i get an ok-to-test to move forward?

@juliusvonkohout juliusvonkohout changed the title feat: allow the default-editor to edit argo workflows feat: allow the default-editor to edit argo workflows and fix bug #6649 Oct 13, 2021
@Bobgy
Copy link
Contributor

Bobgy commented Oct 15, 2021

/ok-to-test
Makes sense to me.
/Cc @zijianjoy
What do you think?
/Lgtm

@juliusvonkohout
Copy link
Member Author

@zijianjoy
What do you think?

@zijianjoy
Copy link
Collaborator

/approve

It looks a legit permission change to me. Thank you for the change.

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zijianjoy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-robot
Copy link

New changes are detected. LGTM label has been removed.

@juliusvonkohout
Copy link
Member Author

/retest

@juliusvonkohout
Copy link
Member Author

@Bobgy @zijianjoy please lgtm again, I had to rebase to master to fix the cicd pipeline

@Bobgy
Copy link
Contributor

Bobgy commented Nov 2, 2021

/lgtm

@google-oss-prow google-oss-prow bot added the lgtm label Nov 2, 2021
@google-oss-robot google-oss-robot merged commit 83ce21f into kubeflow:master Nov 2, 2021
@juliusvonkohout juliusvonkohout mentioned this pull request Nov 16, 2021
Merged
abaland pushed a commit to abaland/pipelines that referenced this pull request May 29, 2022
@juliusvonkohout @abaland
feat: allow the default-editor to edit argo workflows and fix bug kub…
249ceba 
…eflow#6649 (kubeflow#6622)

* Update view-edit-cluster-roles.yaml

* Update view-edit-cluster-roles.yaml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Bobgy Bobgy Awaiting requested review from Bobgy

@zijianjoy zijianjoy Awaiting requested review from zijianjoy

Assignees

@Bobgy Bobgy

Labels
approved cla: yes lgtm ok-to-test size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@juliusvonkohout @google-oss-robot @Bobgy @zijianjoy