SDK/Components/Python - Made the typing.NamedTuple import optional #717
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now it's only imported if the return type is NamedTuple.
qimingj
approved these changes
Jan 23, 2019
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Ark-kun The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
1 similar comment
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Ark-kun The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Ark-kun
deleted the
SDK/Components/Python---Made-the-typing.NamedTuple-import-optional
branch
Linchin
pushed a commit
to Linchin/pipelines
that referenced
this pull request
Apr 11, 2023
…low#717) * handle python2 errors * updated format * Update py/kubeflow/testing/run_e2e_workflow.py * updated to use six
magdalenakuhn17
pushed a commit
to magdalenakuhn17/pipelines
that referenced
this pull request
Oct 22, 2023
…flow#717) * fix inferenceservice url with hyphenated knative domainTemplate * update go version * Merge function VirtualServiceHostname into getServiceHostname * add go version * Update docs/DEVELOPER_GUIDE.md Co-Authored-By: Dan Sun <dsun20@bloomberg.net> * use table based unit test Co-authored-by: Dan Sun <dsun20@bloomberg.net>
HumairAK
pushed a commit
to red-hat-data-services/data-science-pipelines
that referenced
this pull request
Mar 11, 2024
refer the project as Kubeflow Pipelines on Tekton, plus rearrange a bit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes Lightweight Python components more Python2 compatible.
/assign @qimingj @gaoning777 @hongye-sun
This change is