fix(backend): make cache-deployer generate CSR using kubelet-serving signerName #7273
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes:
Fixed #7093
signerName: kubernetes.io/kube-apiserver-client
only can create client certificates. However, we need to create certificates for server auth, so we need to change the singer name tosignerName: kubernetes.io/kubelet-serving
From: https://kubernetes.io/docs/reference/access-authn-authz/certificate-signing-requests/#kubernetes-signers
Section 3:
Also, with the new CertificateSigningRequest V1 API, it requires common name to start with "system:node:"
From: https://kubernetes.io/docs/reference/access-authn-authz/certificate-signing-requests/#kubernetes-signers
Section 3.2:
We tested on Kubernetes 1.22 with KFP v1.8.0-rc1 release
Checklist: