Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(backend): make cache-deployer generate CSR using kubelet-serving signerName #7273

Merged
merged 1 commit into from
Feb 8, 2022

Conversation

Tomcli
Copy link
Member

@Tomcli Tomcli commented Feb 8, 2022

Description of your changes:
Fixed #7093

signerName: kubernetes.io/kube-apiserver-client only can create client certificates. However, we need to create certificates for server auth, so we need to change the singer name to signerName: kubernetes.io/kubelet-serving
From: https://kubernetes.io/docs/reference/access-authn-authz/certificate-signing-requests/#kubernetes-signers
Section 3:

kubernetes.io/kubelet-serving: signs serving certificates that are honored as a valid kubelet serving certificate by the API server, but has no other guarantees. Never auto-approved by kube-controller-manager.

Also, with the new CertificateSigningRequest V1 API, it requires common name to start with "system:node:"
From: https://kubernetes.io/docs/reference/access-authn-authz/certificate-signing-requests/#kubernetes-signers
Section 3.2:

Permitted subjects - organizations are exactly ["system:nodes"], common name starts with "system:node:".

We tested on Kubernetes 1.22 with KFP v1.8.0-rc1 release

Checklist:

@Tomcli Tomcli changed the title fix(backend): make cache-deployer generate CSR using kubelet-serving fix(backend): make cache-deployer generate CSR using kubelet-serving signerName Feb 8, 2022
@chensun
Copy link
Member

chensun commented Feb 8, 2022

@Tomcli thanks for the fix.

Will cherry pick this into the next rc release.

/lgtm
/approve

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chensun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[backend] cache-deployer generate CSR with wrong usage
2 participants