Cleanup pipeline bootstrapper #770
Conversation
|
Hi @ohmystack. Thanks for your PR. I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
1 similar comment
|
Hi @ohmystack. Thanks for your PR. I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@IronPan, could you please have a look? |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: IronPan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
1 similar comment
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: IronPan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ohmystack
force-pushed
the
cleanup-bootstrapper
branch
from
af13477 to
4458ab5
Compare
As pipeline bootstrapper has been removed in kubeflow#739 , the gitignore file and deployment guide should be updated as well.
|
/retest |
|
@ohmystack: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/retest |
1 similar comment
|
/retest |
|
/ok-to-test |
|
@vicaire Can we let this 'gitignore' PR skip the pipeline sample tests? |
|
/retest |
|
Done. Thanks! |
* add tekton pipelinerun for unittest kubeflow#769 * add pipeline yamls * fix pipelinespec indendatation * add tasks to get installed * update the running pipelinerun and add hydrated yamls * correct gcs path * update .pylintrc to ignore over the tests written * comment out tests using _get_actual_junit_files function * update rcfile complete path * add hydrated py-lint update * revert lint and uncomment out tests * use gcr image with sha only
As pipeline bootstrapper has been removed in #739 , the gitignore file
and deployment guide should be updated as well.
This change is