Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(backend): use cert-manager for cache server cert #7839

Closed

Conversation

surajkota
Copy link
Contributor

Description of your changes:

Testing:

  • Manually tested both standalone installation and multi user with Kubeflow installed with a custom built cache-server image since there are changes to backend/src/cache/main.go

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign zijianjoy after the PR has been reviewed.
You can assign the PR to them by writing /assign @zijianjoy in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot requested review from chensun and zijianjoy June 4, 2022 05:04
@google-oss-prow
Copy link

@surajkota: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
kubeflow-pipeline-upgrade-test b91a52d link true /test kubeflow-pipeline-upgrade-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@surajkota
Copy link
Contributor Author

/check cla

@surajkota
Copy link
Contributor Author

/check-cla
/retest

@surajkota
Copy link
Contributor Author

some issue with cla bot, will try opening a new PR

@surajkota surajkota closed this Jun 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant