Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(backend): use cert-manager for cache server cert #7843

Merged

Conversation

surajkota
Copy link
Contributor

@surajkota surajkota commented Jun 4, 2022

Description of your changes:

Testing:

  • Manually tested both standalone installation and multi user with Kubeflow installed with a custom built cache-server image since there are changes to backend/src/cache/main.go

@google-oss-prow google-oss-prow bot requested review from chensun and zijianjoy June 4, 2022 05:24
@zijianjoy
Copy link
Collaborator

/retest-required

@zijianjoy
Copy link
Collaborator

You need to run manifests/gcp_marketplace/test/snapshots.sh to update snapshot

@zijianjoy
Copy link
Collaborator

Created #7852 to fix the mkp-snapshot failure

@google-oss-prow
Copy link

google-oss-prow bot commented Jun 7, 2022

@surajkota: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
kubeflow-pipelines-component-yaml b91a52d link true /test kubeflow-pipelines-component-yaml
kubeflow-pipelines-components-google-cloud-python38 b91a52d link true /test kubeflow-pipelines-components-google-cloud-python38

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@surajkota
Copy link
Contributor Author

/test kubeflow-pipeline-upgrade-test

@zijianjoy
Copy link
Collaborator

#7852 is merged

@zijianjoy
Copy link
Collaborator

zijianjoy commented Jun 8, 2022

/lgtm
/approve

Thank you @surajkota !

CC @chensun as we need to cherry pick this and another PR to 1.8 branch and release a 1.8.2 for this.

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zijianjoy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@surajkota
Copy link
Contributor Author

surajkota commented Jun 8, 2022

Thanks @akartsky for investigating this. Thanks @zijianjoy for prioritizing the review.

@chensun We will need the following 2 PRs to be cherry-picked for 1.8.2:
#7538
#7843

We might need this as well for the tests: #7852

@google-oss-prow google-oss-prow bot merged commit 784f9fa into kubeflow:master Jun 8, 2022
@chensun chensun added the cherrypick-approved area OWNER approves to cherry pick this PR to current active release branch label Jun 9, 2022
@chensun chensun added the cherrypicked cherry picked to release branch `release-x.y` label Jun 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cherrypick-approved area OWNER approves to cherry pick this PR to current active release branch cherrypicked cherry picked to release branch `release-x.y` lgtm size/L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants