-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(frontend): Create sections and run list for KFPv2 Run Comparison page #7882
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Thank you Chris for the change! I will approve this PR once you have cleared the array from useEffect
dependency list. See my comment above.
/lgtm This is awesome work! Thank you Chris! |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: zijianjoy The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description of your changes:
Screencast:
KFPv2.Run.Comparison.Page.Foundations.mp4
Notes:
react-testing-library
instead ofenzyme
, as advised by this earlier discussion: fix(frontend): Fix run comparison filter #7833 (comment)Compare.test.tsx
are updated because theRun overview
text now exists on both the V1 and V2 pages. Since I won't implement the Parameter section until the second half of the internship, I used the existence or absence of that temporary text (Parameter Section V2
) to test whether the V1 or V2 page is shown (I will change this again after I add the Parameter section).CompareV1
page and test suite.Checklist: