Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(frontend): Create sections and run list for KFPv2 Run Comparison page #7882

Merged
merged 13 commits into from
Jun 16, 2022
Merged

feat(frontend): Create sections and run list for KFPv2 Run Comparison page #7882

merged 13 commits into from
Jun 16, 2022

Conversation

zpChris
Copy link
Contributor

@zpChris zpChris commented Jun 10, 2022

Description of your changes:

  1. Add the header buttons: Expand all, Collapse all, and Refresh
  2. Add the three section components: Run Overview, Parameters, and Metrics
  3. Add the run list content within the "Run Overview" section

Screencast:

KFPv2.Run.Comparison.Page.Foundations.mp4

Notes:

  • These additions are identical to the KFPv1 Run Comparison page (without the "Parameters" and "Metrics" content), but they are implemented using functional components rather than class components.
  • The tests in Compare.test.tsx are updated because the Run overview text now exists on both the V1 and V2 pages. Since I won't implement the Parameter section until the second half of the internship, I used the existence or absence of that temporary text (Parameter Section V2) to test whether the V1 or V2 page is shown (I will change this again after I add the Parameter section).
  • This is a large PR with lots of additions, but they are all essentially modeled after the existing implementation of the CompareV1 page and test suite.

Checklist:

frontend/src/pages/CompareV2.tsx Outdated Show resolved Hide resolved
frontend/src/pages/CompareV2.tsx Outdated Show resolved Hide resolved
@zpChris zpChris requested review from zijianjoy and removed request for StefanoFioravanzo June 11, 2022 17:21
frontend/src/pages/CompareV2.tsx Outdated Show resolved Hide resolved
frontend/src/pages/CompareV2.tsx Outdated Show resolved Hide resolved
frontend/src/pages/CompareV2.tsx Show resolved Hide resolved
frontend/src/pages/CompareV2.tsx Outdated Show resolved Hide resolved
frontend/src/pages/CompareV2.tsx Outdated Show resolved Hide resolved
@google-oss-prow google-oss-prow bot added size/XL and removed size/L labels Jun 13, 2022
@zpChris zpChris requested a review from zijianjoy June 14, 2022 17:20
Copy link
Collaborator

@zijianjoy zijianjoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Thank you Chris for the change! I will approve this PR once you have cleared the array from useEffect dependency list. See my comment above.

@google-oss-prow google-oss-prow bot added the lgtm label Jun 16, 2022
@google-oss-prow google-oss-prow bot removed the lgtm label Jun 16, 2022
@zijianjoy
Copy link
Collaborator

/lgtm
/approve

This is awesome work! Thank you Chris!

@google-oss-prow google-oss-prow bot added the lgtm label Jun 16, 2022
@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zijianjoy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 146dae7 into kubeflow:master Jun 16, 2022
@zpChris zpChris deleted the add-v2-run-list branch June 16, 2022 22:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants