feat: Upload namespaced pipeline definitions. Part of #4197 #8360
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Autogenerate Go and Python clients for the updated gRPC-Gateway which got reverted by f604406
Fix the way KFP API server authenticates pipeline upload requests. We leverage 'isAuthenticated()` function which requires proper initialization of the context object to include user identity.
Extend swagger defintion of the pipeline upload API with a namespace parameter in order to support uploading namespaced pipelines.
Autogenerate the updated Go and Python clients after extending the swagger definitions of upload pipeline APIs with a namespace field.
Add a namespace field in the relevant Python wrappers for uploading pipeline definitions.
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Ah CLA got fixed in #8196. Sorry for this, closing this PR. Let's continue using the other one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[This is a re-opening of #8196.]
Description of your changes:
This PR is part of the overarching idea to support namespaced pipeline definitions.
The whole idea is thoroughly analyzed and exposed in this design doc: https://docs.google.com/document/d/1fM4y2L1IVqVj-iiNjYFRRktdCh7FQXgU2XpaYLaqt-A/edit?resourcekey=0-kd5loyP7w3PBD0ug6ECmLQ#
You will notice that in the first commit we autogenerate the Go and Python clients. We did this because commit f604406 reverted the change of cf1b873 for some reason. We didn't find any rationale for this somewhere, it looks like it was not pushed with a PR.
Objective of this PR is to:
Refs #4197
Checklist: