Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(backend): Include namespace in Pipeline API model. Part of #4197 #8375

Conversation

elikatsis
Copy link
Member

Description of your changes:

This PR enables including the namespace of a pipeline as a resource reference in the Pipeline API response. For more details and the main drive for it, PTAL #4197 (comment).

Checklist:

@juliusvonkohout
Copy link
Member

/lgtm

@difince this might affect your API redesign.

@difince
Copy link
Member

difince commented Oct 18, 2022

Thank you @juliusvonkohou.
Namespace being part of the response is part of API v2.

LGTM

@chensun
Copy link
Member

chensun commented Oct 21, 2022

/lgtm

/assign @Linchin

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chensun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 7c114a0 into kubeflow:master Oct 26, 2022
@elikatsis elikatsis deleted the feature-elikatsis-pipelines-incl-namespace branch October 27, 2022 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants