feat(backend): Upload namespaced pipeline definitions. Part of #4197 #8511
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix the way KFP API server authenticates pipeline upload requests. We leverage 'isAuthenticated()` function which requires proper initialization of the context object to include user identity.
Extend swagger defintion of the pipeline upload API with a namespace parameter in order to support uploading namespaced pipelines.
Autogenerate the Go and Python clients after extending the swagger definitions of upload pipeline APIs with a namespace field.
|
/cc @chensun @zijianjoy @jlyaoyuli @Linchin @juliusvonkohout @StefanoFioravanzo |
google-oss-prow
bot
requested review from
chensun,
jlyaoyuli,
juliusvonkohout,
StefanoFioravanzo and
zijianjoy
1 task
|
@elikatsis i strongly suggest putting this on the agenda for the next KFP meeting. As you have seen the previous PR only got attention after i did that. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chensun The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@elikatsis run-frontend-integration-tests failed in kubeflow-pipeline-e2e-test |
|
/retest |
elikatsis
deleted the
feature-pangiann-upload-namespaced-pipelines-backend
branch
jlyaoyuli
pushed a commit
to jlyaoyuli/pipelines
that referenced
this pull request
Jan 5, 2023
…ow#4197 (kubeflow#8511) * feat(backend) Fix authentication in upload requests Fix the way KFP API server authenticates pipeline upload requests. We leverage 'isAuthenticated()` function which requires proper initialization of the context object to include user identity. * feat(backend): Add namespace field in pipeline upload swagger definition Extend swagger defintion of the pipeline upload API with a namespace parameter in order to support uploading namespaced pipelines. * chore(backend): Generate Go & Python clients Autogenerate the Go and Python clients after extending the swagger definitions of upload pipeline APIs with a namespace field.
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes:
This is the backend part pushed by #8196. See the aforementioned PR and the linked issued for details.
This PR is part of the overarching idea to support namespaced pipeline definitions.
The whole idea is thoroughly analyzed and exposed in this design doc: https://docs.google.com/document/d/1fM4y2L1IVqVj-iiNjYFRRktdCh7FQXgU2XpaYLaqt-A/edit?resourcekey=0-kd5loyP7w3PBD0ug6ECmLQ#
Objective of this PR is to:
Part of #4197
Checklist: