Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(manifests): Change mysql default binlog expire to 10 days. Fixes #8552 #8553

Merged
merged 2 commits into from
Dec 9, 2022

Conversation

chensun
Copy link
Member

@chensun chensun commented Dec 9, 2022

Description of your changes:
Fixes #8552

Checklist:

Copy link
Member

@gkcalat gkcalat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @chensun! Should we add this to release-1.8 branch?

@google-oss-prow google-oss-prow bot added size/S and removed size/XS labels Dec 9, 2022
@chensun
Copy link
Member Author

chensun commented Dec 9, 2022

Thank you @chensun! Should we add this to release-1.8 branch?

It looks like we didn't upgrade mysql version in release-1.8.

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: gkcalat

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gkcalat
Copy link
Member

gkcalat commented Dec 9, 2022

Thank you @chensun! Should we add this to release-1.8 branch?

It looks like we didn't upgrade mysql version in release-1.8.

Oh yes, I recall now :)

@google-oss-prow google-oss-prow bot merged commit 352f1c6 into kubeflow:master Dec 9, 2022
@chensun chensun deleted the mysql-binlog-expire branch December 15, 2022 03:39
jlyaoyuli pushed a commit to jlyaoyuli/pipelines that referenced this pull request Jan 5, 2023
…ubeflow#8552 (kubeflow#8553)

* Change mysql default binlog expire to 10 days

* add comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MySQL logs disk full error
2 participants