Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update copyright #880

Closed
wants to merge 2 commits into from
Closed

update copyright #880

wants to merge 2 commits into from

Conversation

IronPan
Copy link
Member

@IronPan IronPan commented Feb 28, 2019

This change is Reviewable

@IronPan
Copy link
Member Author

IronPan commented Feb 28, 2019

/assign @vicaire @yebrahim

@vicaire
Copy link
Contributor

vicaire commented Feb 28, 2019

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vicaire

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@yebrahim
Copy link
Contributor

yebrahim commented Feb 28, 2019

Oh, sorry if I wasn't clear on my earlier comment (assuming this is to tackle that). Only new files should have the 2019 copyright headers, older ones shouldn't change.
/hold

@k8s-ci-robot
Copy link
Contributor

New changes are detected. LGTM label has been removed.

1 similar comment
@k8s-ci-robot
Copy link
Contributor

New changes are detected. LGTM label has been removed.

@gaoning777
Copy link
Contributor

Should newly created files use 2019 copyright?

@vicaire
Copy link
Contributor

vicaire commented Mar 12, 2019

Yes. Thanks!

Linchin pushed a commit to Linchin/pipelines that referenced this pull request Apr 11, 2023
HumairAK pushed a commit to red-hat-data-services/data-science-pipelines that referenced this pull request Mar 11, 2024
…ubeflow#881)

* add test for custom-tasks with literals

* fix orig_params check for custom tasks

* fix: style: min 2 spaces before inline comment

* fix: style: 2 empty line before function decl
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants