Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: install compatible kfp-server-api and kfp packages #8829

Merged
merged 2 commits into from
Feb 9, 2023

Conversation

chensun
Copy link
Member

@chensun chensun commented Feb 9, 2023

Description of your changes:
kfp (sdk) from HEAD and kfp-server-api from HEAD may not always be compatible. This could happen anytime API changes, and SDK may not integrate with API changes at the same time.

Checklist:

Copy link
Member

@gkcalat gkcalat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we keep the kfp-server-api as >= in SDK requirements to install kfp from master?

@google-oss-prow google-oss-prow bot added size/M and removed size/XS labels Feb 9, 2023
@google-oss-prow
Copy link

google-oss-prow bot commented Feb 9, 2023

@chensun: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
kubeflow-pipelines-sdk-yapf 2511cea link true /test kubeflow-pipelines-sdk-yapf
kubeflow-pipelines-sdk-execution-tests 2511cea link true /test kubeflow-pipelines-sdk-execution-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@google-oss-prow google-oss-prow bot added size/XS and removed size/M labels Feb 9, 2023
@chensun chensun changed the title test: install only kfp from HEAD, but not kfp-server-api test: install compatible kfp-server-api and kfp packages Feb 9, 2023
@gkcalat
Copy link
Member

gkcalat commented Feb 9, 2023

/lgtm
/approve

Thanks!

@google-oss-prow google-oss-prow bot added the lgtm label Feb 9, 2023
@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gkcalat

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit fd3f694 into kubeflow:master Feb 9, 2023
@chensun chensun deleted the sample-test branch February 9, 2023 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants