Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Infra - Added license for google-cloud-bigtable #896

Conversation

Ark-kun
Copy link
Contributor

@Ark-kun Ark-kun commented Mar 1, 2019

This change is Reviewable

@IronPan
Copy link
Member

IronPan commented Mar 1, 2019

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: IronPan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

1 similar comment
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: IronPan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 788d8c6 into kubeflow:master Mar 2, 2019
@Ark-kun Ark-kun deleted the Added-license-for-google-cloud-bigtable branch March 2, 2019 01:34
@Ark-kun Ark-kun changed the title Added license for google-cloud-bigtable Infra - Added license for google-cloud-bigtable Mar 8, 2019
cheyang pushed a commit to alibaba/pipelines that referenced this pull request Mar 28, 2019
magdalenakuhn17 pushed a commit to magdalenakuhn17/pipelines that referenced this pull request Oct 22, 2023
…erenceservices.yaml. (kubeflow#896)

* Fix batcher format issue and generate CRD in serving.kubeflow.org_inferenceservices.yaml.

* Fix batcher format issue and generate CRD in serving.kubeflow.org_inferenceservices.yaml.
HumairAK pushed a commit to red-hat-data-services/data-science-pipelines that referenced this pull request Mar 11, 2024
* add tests for non-literal separator

* plug-in the tests

* process 'separator' like 'from'-'step'-'to'

* explicitly allow PipelineParam as a separator
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants