Watson Openscale Components to manage models #950
Conversation
|
/approve |
|
/assign @Tomcli |
|
@Tomcli: GitHub didn't allow me to assign the following users: Tomcli. Note that only kubeflow members and repo collaborators can be assigned and that issues/PRs can only have 10 assignees at the same time. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
1 similar comment
|
@Tomcli: GitHub didn't allow me to assign the following users: Tomcli. Note that only kubeflow members and repo collaborators can be assigned and that issues/PRs can only have 10 assignees at the same time. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@animeshsingh: GitHub didn't allow me to assign the following users: Tomcli. Note that only kubeflow members and repo collaborators can be assigned and that issues/PRs can only have 10 assignees at the same time. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
1 similar comment
|
@animeshsingh: GitHub didn't allow me to assign the following users: Tomcli. Note that only kubeflow members and repo collaborators can be assigned and that issues/PRs can only have 10 assignees at the same time. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
components/ibm-components/watson/manage/monitor_fairness/src/enable_fairness_monitoring.py
Outdated
Show resolved
Hide resolved
| @@ -0,0 +1,123 @@ | |||
| import json | |||
There was a problem hiding this comment.
This file is a program, but it's not fully obvious what exactly it is doing. If you prefix the name with a verb it would be easier to understand.
There was a problem hiding this comment.
Fixed in the latest push by @Tomcli
|
General comment: |
|
It would be great if you've added |
|
Otherwise |
|
So there's good news and bad news. 👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there. 😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request. Note to project maintainer: This is a terminal state, meaning the ℹ️ Googlers: Go here for more info. |
|
I agree with my commits being contributed to this project. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Tomcli, vicaire The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
| implementation: | ||
| container: | ||
| image: docker.io/aipipeline/monitor_fairness:latest | ||
| args: [ |
There was a problem hiding this comment.
General comment: To future-proof your component it's desirable to also specify the command-line (command:). Having the full command-line available allows adding some special wrappers to it.
|
Thanks for fixing all the issues. |
* openscale componenets to manage models * renamed component filename, updated with component.yaml (#1)
…ng/cloudprovider/aws (kubeflow#950) Bumps [urllib3](https://github.com/urllib3/urllib3) from 1.26.4 to 1.26.5. - [Release notes](https://github.com/urllib3/urllib3/releases) - [Changelog](https://github.com/urllib3/urllib3/blob/main/CHANGES.rst) - [Commits](urllib3/urllib3@1.26.4...1.26.5) --- updated-dependencies: - dependency-name: urllib3 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
To be used in a subsequent pipeline being drafted. Enables fairness and quality monitoring
This change is