Skip to content

Commit

Permalink
Add specific error in log line when failed to create web UI service (#…
Browse files Browse the repository at this point in the history
…2170)

* Add specific error in log line when failed to create web UI service

Signed-off-by: tcassaert <tcassaert@inuits.eu>

* Update log to reflect correct resource that could not be created

Co-authored-by: Yi Chen <github@chenyicn.net>
Signed-off-by: tcassaert <tcassaert@protonmail.com>

---------

Signed-off-by: tcassaert <tcassaert@inuits.eu>
Signed-off-by: tcassaert <tcassaert@protonmail.com>
Co-authored-by: Yi Chen <github@chenyicn.net>
  • Loading branch information
tcassaert and ChenYi015 authored Sep 19, 2024
1 parent 59a8ca4 commit ed3226e
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions internal/controller/sparkapplication/controller.go
Original file line number Diff line number Diff line change
Expand Up @@ -672,7 +672,7 @@ func (r *Reconciler) submitSparkApplication(app *v1beta2.SparkApplication) error
if r.options.EnableUIService {
service, err := r.createWebUIService(app)
if err != nil {
return fmt.Errorf("failed to create web UI service")
return fmt.Errorf("failed to create web UI service: %v", err)
}
app.Status.DriverInfo.WebUIServiceName = service.serviceName
app.Status.DriverInfo.WebUIPort = service.servicePort
Expand All @@ -696,7 +696,7 @@ func (r *Reconciler) submitSparkApplication(app *v1beta2.SparkApplication) error
}
ingress, err := r.createWebUIIngress(app, *service, ingressURL, r.options.IngressClassName)
if err != nil {
return fmt.Errorf("failed to create web UI service")
return fmt.Errorf("failed to create web UI ingress: %v", err)
}
app.Status.DriverInfo.WebUIIngressAddress = ingress.ingressURL.String()
app.Status.DriverInfo.WebUIIngressName = ingress.ingressName
Expand Down

0 comments on commit ed3226e

Please sign in to comment.