Skip to content

Add timeZone to ScheduledSparkApplication #2471

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 31, 2025
Merged

Add timeZone to ScheduledSparkApplication #2471

merged 2 commits into from
Mar 31, 2025

Conversation

jacobsalway
Copy link
Member

@jacobsalway jacobsalway commented Mar 16, 2025 •
edited
Loading

Purpose of this PR

  • Allow a timezone to be specified in a ScheduledSparkApplication
  • Explicitly validate the timezone for better user feedback
  • Ensure backwards compatibility if any users are relying on CRON_TZ= or TZ= prefixes in the schedule field being parsed by robfig/cron

Close #1712
Close #2328

Change Category

  • Bugfix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that could affect existing functionality)
  • Documentation update

Checklist

  • I have conducted a self-review of my own code.
  • I have updated documentation accordingly.
  • I have added tests that prove my changes are effective or that my feature works.
  • Existing unit tests pass locally with my changes.

@jacobsalway jacobsalway force-pushed the add-timezone-to-scheduled-sparkapp branch from f430a69 to 30cf98a Compare March 16, 2025 21:42
@google-oss-prow google-oss-prow bot added size/M and removed size/S labels Mar 16, 2025
@jacobsalway jacobsalway force-pushed the add-timezone-to-scheduled-sparkapp branch from 30cf98a to 36476e1 Compare March 16, 2025 21:42
@jacobsalway jacobsalway changed the title Add timeZone to ScheduledSparkApplication Add timeZone to ScheduledSparkApplication Mar 16, 2025
@jacobsalway jacobsalway force-pushed the add-timezone-to-scheduled-sparkapp branch from 36476e1 to c077df6 Compare March 27, 2025 11:20
jacobsalway
jacobsalway commented Mar 27, 2025
View reviewed changes
@jacobsalway
Add timeZone to ScheduledSparkApplication
230263d 
Signed-off-by: Jacob Salway <jacob.salway@gmail.com>
@jacobsalway jacobsalway force-pushed the add-timezone-to-scheduled-sparkapp branch from c077df6 to 230263d Compare March 27, 2025 12:57
@jacobsalway jacobsalway marked this pull request as ready for review March 27, 2025 13:00
@google-oss-prow google-oss-prow bot requested a review from vara-bonthu March 27, 2025 13:00
@jacobsalway
Copy link
Member Author

/assign @ChenYi015

ChenYi015
ChenYi015 approved these changes Mar 29, 2025
View reviewed changes
@jacobsalway @ChenYi015
Update api/v1beta2/scheduledsparkapplication_types.go
725f262 
Co-authored-by: Yi Chen <github@chenyicn.net>
Signed-off-by: Jacob Salway <jacob.salway@gmail.com>
@google-oss-prow Google OSS Prow
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ChenYi015, vara-bonthu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [ChenYi015,vara-bonthu]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ChenYi015
Copy link
Contributor

/lgtm

@google-oss-prow google-oss-prow bot added the lgtm label Mar 31, 2025
@google-oss-prow google-oss-prow bot merged commit 50ae7a0 into kubeflow:master Mar 31, 2025
16 checks passed
@jacobsalway jacobsalway deleted the add-timezone-to-scheduled-sparkapp branch March 31, 2025 03:15
@ChenYi015 ChenYi015 mentioned this pull request May 29, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nabuskey nabuskey nabuskey left review comments

@vara-bonthu vara-bonthu vara-bonthu approved these changes

@ChenYi015 ChenYi015 ChenYi015 approved these changes

@andreyvelich andreyvelich Awaiting requested review from andreyvelich

@ImpSy ImpSy Awaiting requested review from ImpSy

@mwielgus mwielgus Awaiting requested review from mwielgus

Assignees

@ChenYi015 ChenYi015

Labels
approved lgtm size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support for timeZone in Scheduled Spark Jobs Add timeZone support for ScheduledSparkApplications
4 participants
@jacobsalway @ChenYi015 @vara-bonthu @nabuskey