Fix cleanup_ci.py - fix cleanup of argo workflows and IAM policy bindings #359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add logging to make it easier to monitor progress. * Print out stack traces on errors. * cleanup_workflows needs to get GKE credentials. * The project might be different from the project where KF is deployed. Related to kubeflow#358 cleanup ci not cleaning up Argo workflows Related to kubeflow#357 cleanup ci not cleaning up IAM policies. * Fix bug in cleaning up Argo workflows; we should not break out of loop. * Don't exit if delete of Workflow fails; it looks like there might be some race conditions. * Update the docker image to use google-api-python-client library 1.7.0 instead of 1.6.5. It looks like using 1.6.5 gives us an error when getting IAM policy.
|
/assign @gabrielwen |
jlewi
changed the title
gabrielwen
reviewed
Apr 16, 2019
| @@ -21,6 +21,7 @@ RUN set -ex \ | |||
| wget \ | |||
| ca-certificates \ | |||
| git \ | |||
| emacs \ | |||
There was a problem hiding this comment.
Its convenient for debugging; e.g. manually editing of files.
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jlewi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix cleanup_ci.py - cleaning of Argo and service account binding
Add logging to make it easier to monitor progress.
Print out stack traces on errors.
cleanup_workflows needs to get GKE credentials.
Related to #358 cleanup ci not cleaning up Argo workflows
Related to #357 cleanup ci not cleaning up IAM policies.
Fix bug in cleaning up Argo workflows; we should not break out of loop.
Don't exit if delete of Workflow fails; it looks like there might be
some race conditions.
Update the docker image to use google-api-python-client library 1.7.0 instead
of 1.6.5. It looks like using 1.6.5 gives us an error when getting IAM
policy.
Prune the OWNERs file to remove a bunch of approvers who haven't been active.
This change is