Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Argo workflows's should stick around for a week or so. #363

Merged
merged 1 commit into from
Apr 19, 2019

Conversation

jlewi
Copy link
Contributor

@jlewi jlewi commented Apr 19, 2019

  • Argo workflows were being GC'd after 3 hours like other resources. That is
    too aggressive. We want the workflows to be around longer to aid debugging.
  • Fix 362

This change is Reviewable

* Argo workflows were being GC'd after 3 hours like other resources. That is
too aggressive. We want the workflows to be around longer to aid debugging.
* Fix 362
@jlewi
Copy link
Contributor Author

jlewi commented Apr 19, 2019

/assign @gabrielwen
/assign @zhenghuiwang

Copy link
Contributor

@gabrielwen gabrielwen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@zhenghuiwang
Copy link
Contributor

/lgtm

@jlewi
Copy link
Contributor Author

jlewi commented Apr 19, 2019

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jlewi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 0ce809b into kubeflow:master Apr 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants