Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attach appropriate header (copyright) to go files #266

Closed
wackxu opened this issue Jan 5, 2018 · 14 comments
Closed

Attach appropriate header (copyright) to go files #266

wackxu opened this issue Jan 5, 2018 · 14 comments

Comments

@wackxu
Copy link
Contributor

wackxu commented Jan 5, 2018

@jlewi @zjj2wry @gaocegege @ScorpioCPH

@gaocegege
Copy link
Member

gaocegege commented Jan 5, 2018

Do you mean the copyright header? I am not sure if I understand your idea 🤔

@wackxu
Copy link
Contributor Author

wackxu commented Jan 5, 2018

@gaocegege Yes, copyright header for go files is confused, we can make a boilerplate for all go files

@gaocegege
Copy link
Member

SGTM

@ScorpioCPH
Copy link
Member

copyright header for go files is confused.

Do you mean we need an auto-generate script?

@jlewi jlewi changed the title make boilerplate unify for all go files Attach appropriate header (copyright) to go files Jan 5, 2018
@jlewi
Copy link
Contributor

jlewi commented Jan 5, 2018

Does anyone have a link to what the requirements are for copyrigh/license headers?

/cc @foxish @vishh @aronchick

@aronchick
Copy link

uh, no idea. /cc @ewilderj

@jlewi jlewi added this to the Kubecon Europe milestone Jan 25, 2018
@gaocegege
Copy link
Member

Who should be the copyright owner: google or kubeflow? I think we should communicate with the community.

@jlewi
Copy link
Contributor

jlewi commented Feb 1, 2018

I think it has to be Google until Kubeflow becomes part of a foundation (e.g. CNCF). At which point CNCF can be used.

@gaocegege
Copy link
Member

@jlewi Well, I will file a PR to solve the issue.

@ewilderj
Copy link

ewilderj commented Feb 1, 2018

Actually, it doesn't have to be Google. For TensorFlow, it is just "The TensorFlow Authors." I will check out what ought to be recommended for us, but as a working presumption, I'd go with "The Kubeflow Authors."

@jlewi
Copy link
Contributor

jlewi commented Feb 1, 2018 via email

@ewilderj
Copy link

ewilderj commented Feb 1, 2018

I can confirm that "Copyright The Kubeflow Authors" is the right copyright line, followed by the Apache 2 header.

@gaocegege
Copy link
Member

@ewilderj The Kubeflow Authors SGTM, and I will update the PR 😄

@jlewi jlewi closed this as completed in #364 Feb 2, 2018
jlewi pushed a commit that referenced this issue Feb 2, 2018
* *: Add copyright owner in go files

Close #266

Signed-off-by: Ce Gao <gaoce@caicloud.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants