-
Notifications
You must be signed in to change notification settings - Fork 699
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Attach appropriate header (copyright) to go files #266
Comments
Do you mean the copyright header? I am not sure if I understand your idea 🤔 |
@gaocegege Yes, copyright header for go files is confused, we can make a boilerplate for all go files |
SGTM |
Do you mean we need an auto-generate script? |
Does anyone have a link to what the requirements are for copyrigh/license headers? /cc @foxish @vishh @aronchick |
uh, no idea. /cc @ewilderj |
Who should be the copyright owner: google or kubeflow? I think we should communicate with the community. |
I think it has to be Google until Kubeflow becomes part of a foundation (e.g. CNCF). At which point CNCF can be used. |
@jlewi Well, I will file a PR to solve the issue. |
Actually, it doesn't have to be Google. For TensorFlow, it is just "The TensorFlow Authors." I will check out what ought to be recommended for us, but as a working presumption, I'd go with "The Kubeflow Authors." |
Great
…On Feb 1, 2018 7:35 AM, "Edd Wilder-James" ***@***.***> wrote:
Actually, it doesn't have to be Google. For TensorFlow, it is just "The
TensorFlow Authors." I will check out what ought to be recommended for us,
but as a working presumption, I'd go with "The Kubeflow Authors."
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#266 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAvcA6DljuztmPpw3suIA1Hi9_MJBNb2ks5tQdm0gaJpZM4RT7Px>
.
|
I can confirm that "Copyright The Kubeflow Authors" is the right copyright line, followed by the Apache 2 header. |
@ewilderj The Kubeflow Authors SGTM, and I will update the PR 😄 |
* *: Add copyright owner in go files Close #266 Signed-off-by: Ce Gao <gaoce@caicloud.io>
@jlewi @zjj2wry @gaocegege @ScorpioCPH
The text was updated successfully, but these errors were encountered: