Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v1alpha2 - pod names don't include replica type #633

Closed
jlewi opened this issue Jun 11, 2018 · 2 comments · Fixed by #636
Closed

v1alpha2 - pod names don't include replica type #633

jlewi opened this issue Jun 11, 2018 · 2 comments · Fixed by #636

Comments

@jlewi
Copy link
Contributor

jlewi commented Jun 11, 2018

I'm running a simple v1alpha2 job and I'm noticing the pod names don't include the replica type.

kubectl -n kubeflow-test-infra get pods
NAME               READY     STATUS    RESTARTS   AGE
simple-001-67mg5   1/1       Running   0          2m
simple-001-89btz   1/1       Running   0          2m
simple-001-ldvd2   1/1       Running   0          2m
simple-001-tg79w   1/1       Running   0          2m
simple-001-wxp2s   1/1       Running   0          2m
simple-001-xfhdt   1/1       Running   0          2m

This is for a job with 2 PS and 4 workers.

Is this intentional? I'd have to double check but my sense is in v1alpha1 pod names included the replica type in the name.

@gaocegege
Copy link
Member

I will take a look.

@gaocegege gaocegege self-assigned this Jun 12, 2018
@gaocegege
Copy link
Member

We are using podcontrol in Kubernetes to create pods with the given parent object TFJob, and the code uses the name of the parent TFJob as the generateName to generate the name of the pod, I will try to hack it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants