-
Notifications
You must be signed in to change notification settings - Fork 699
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
E2E test to validate pod names #645
Comments
I will try this one |
We've added a bunch of E2E tests to TFJob operator; its possible we now have test coverage for this; we should check. |
I don't think anyone is working on this; should we punt to 0.5? /cc @richardsliu |
This is somewhat covered by recent e2e tests. For example the runconfig e2e tests will send request specifically to service endpoints with the assumption that the pod names are formatted as "[job-name]-[replica-type]-[index]". But it may be good to explicitly validate the names. |
We had some regressions with v1alpha2 with pod names:
See #644 & #633 we should consider adding an E2E test to prevent regressions.
The text was updated successfully, but these errors were encountered: