Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

E2E test to validate pod names #645

Closed
jlewi opened this issue Jun 12, 2018 · 4 comments
Closed

E2E test to validate pod names #645

jlewi opened this issue Jun 12, 2018 · 4 comments

Comments

@jlewi
Copy link
Contributor

jlewi commented Jun 12, 2018

We had some regressions with v1alpha2 with pod names:

See #644 & #633 we should consider adding an E2E test to prevent regressions.

@lluunn
Copy link
Contributor

lluunn commented Jun 19, 2018

I will try this one

@jlewi
Copy link
Contributor Author

jlewi commented Sep 3, 2018

We've added a bunch of E2E tests to TFJob operator; its possible we now have test coverage for this; we should check.

@jlewi
Copy link
Contributor Author

jlewi commented Dec 3, 2018

I don't think anyone is working on this; should we punt to 0.5?

/cc @richardsliu

@jlewi jlewi removed the area/0.4.0 label Dec 17, 2018
@jlewi jlewi removed this from the 0.4.0 milestone Dec 17, 2018
@richardsliu
Copy link
Contributor

This is somewhat covered by recent e2e tests. For example the runconfig e2e tests will send request specifically to service endpoints with the assumption that the pod names are formatted as "[job-name]-[replica-type]-[index]". But it may be good to explicitly validate the names.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants