Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP don't review #687

Closed
wants to merge 5 commits into from
Closed

WIP don't review #687

wants to merge 5 commits into from

Conversation

lluunn
Copy link
Contributor

@lluunn lluunn commented Jun 19, 2018

For #645


This change is Reviewable

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: gaocegege

Assign the PR to them by writing /assign @gaocegege in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@coveralls
Copy link

coveralls commented Jun 20, 2018

Coverage Status

Coverage increased (+1.1%) to 59.116% when pulling 02e2500 on lluunn:test_pod_name into 3d9afd1 on kubeflow:master.

@lluunn lluunn closed this Jun 20, 2018
@lluunn lluunn reopened this Jun 22, 2018
@lluunn
Copy link
Contributor Author

lluunn commented Jun 22, 2018

/retest

@k8s-ci-robot
Copy link

@lluunn: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
kubeflow-tf-operator-presubmit 02e2500 link /test kubeflow-tf-operator-presubmit

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@jlewi
Copy link
Contributor

jlewi commented Jul 27, 2018

@lluunn Should we close this PR?

@lluunn lluunn closed this Jul 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants