Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix all client request that needs contexts #1292

Merged

Conversation

Jeffwan
Copy link
Member

@Jeffwan Jeffwan commented Jul 5, 2021

Address #1289
This is a follow up PR of #1290

/cc @terrytangyuan @zw0610

Signed-off-by: Jiaxin Shan seedjeffwan@gmail.com

Signed-off-by: Jiaxin Shan <seedjeffwan@gmail.com>
Copy link
Member

@terrytangyuan terrytangyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@Jeffwan
Copy link
Member Author

Jeffwan commented Jul 5, 2021

/approve

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Jeffwan, terrytangyuan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-robot google-oss-robot merged commit d72641c into kubeflow:all-in-one-operator Jul 5, 2021
@Jeffwan Jeffwan deleted the fix_tf_context_issue branch July 5, 2021 23:19
Jeffwan added a commit that referenced this pull request Aug 5, 2021
Signed-off-by: Jiaxin Shan <seedjeffwan@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants