Fix XGBoost container name in log message #1362
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/lgtm |
Jeffwan
approved these changes
Aug 14, 2021
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Jeffwan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@andreyvelich Yes, we do. I may forget to create that issue. We planned to use CRD Validation and this is client side validation and validation rules will be populated in the CRD definition. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I fixed name in XGBoostJob validation.
Btw, is it fine that we don't run this validation before Job submission ?
As I can see, user can detect that Job is not valid only from the controller logs, even if YAML is incorrect: https://github.com/kubeflow/tf-operator/blob/master/pkg/controller.v1/xgboost/xgboostjob_controller.go#L146-L148.
Do we have any method to detect that YAML is valid other than validation webhook ?
cc @kubeflow/wg-training-leads