Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: volcano pod group creation issue #1390

Merged
merged 1 commit into from
Aug 30, 2021
Merged

fix: volcano pod group creation issue #1390

merged 1 commit into from
Aug 30, 2021

Conversation

Jeffwan
Copy link
Member

@Jeffwan Jeffwan commented Aug 29, 2021 •
edited
Loading

Address #1382

A related PR is filed in kubeflow/common#155
This PR would be updated after kubeflow/common release a patch version.

Follow Ce's PR #1384 and make the change on master

/cc @gaocegege @qiankunli @kubeflow/wg-training-leads

Jeffwan
Jeffwan commented Aug 30, 2021
View reviewed changes
go.mod Outdated Show resolved Hide resolved
@Jeffwan
Copy link
Member Author

Jeffwan commented Aug 30, 2021

/hold

@Jeffwan
Copy link
Member Author

Jeffwan commented Aug 30, 2021

oh. I didn't notice ce filed #1384. I will close this one and follow the same way on master

@Jeffwan Jeffwan closed this Aug 30, 2021
@Jeffwan
Copy link
Member Author

Jeffwan commented Aug 30, 2021 •
edited
Loading

/reopen

Just notice Ce's change was checked into v1.2-branch only

@google-oss-robot
Copy link

@Jeffwan: Reopened this PR.

In response to this:

/reopen

Just notice in master, we don't have informer and needs to this way

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Jeffwan Jeffwan changed the title [WIP] fix: volcano pod group creation issue fix: volcano pod group creation issue Aug 30, 2021
@Jeffwan
Copy link
Member Author

Jeffwan commented Aug 30, 2021

/hold cancel

gaocegege
gaocegege reviewed Aug 30, 2021
View reviewed changes
Copy link
Member

@gaocegege gaocegege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gaocegege
Copy link
Member

/approve

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gaocegege

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-robot google-oss-robot merged commit 7f21af3 into kubeflow:master Aug 30, 2021
@Jeffwan Jeffwan deleted the fix_volcano branch August 30, 2021 02:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gaocegege gaocegege gaocegege left review comments

@jinchihe jinchihe Awaiting requested review from jinchihe

@terrytangyuan terrytangyuan Awaiting requested review from terrytangyuan

Assignees

@gaocegege gaocegege

Labels
approved lgtm size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Jeffwan @google-oss-robot @gaocegege