Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

format the python files with yapf #429

Merged
merged 1 commit into from
Mar 2, 2018
Merged

format the python files with yapf #429

merged 1 commit into from
Mar 2, 2018

Conversation

mitake
Copy link
Contributor

@mitake mitake commented Mar 1, 2018 •
edited by jlewi
Loading

This change is Reviewable

@mitake mitake mentioned this pull request Mar 1, 2018
Merged
@gaocegege
Copy link
Member

/ok-to-test

@jlewi Could we invite mitake to be a member of kubeflow then we don't need to enable his PR's test

@gaocegege
Copy link
Member

/lgtm

@coveralls
Copy link

coveralls commented Mar 1, 2018 •
edited
Loading

Coverage Status

Coverage remained the same at 27.475% when pulling 56e2713 on mitake:yapf into 0928271 on kubeflow:master.

@gaocegege
Copy link
Member

@mitake The Travis failed because of #428 , so no need to worry about it.

@gaocegege gaocegege mentioned this pull request Mar 1, 2018
Merged
@jimexist
Copy link
Member

jimexist commented Mar 1, 2018

should've been caught by CI

@gaocegege
Copy link
Member

@mitake #428 is merged, please rebase and let travis do its work again.

@k8s-ci-robot k8s-ci-robot removed the lgtm label Mar 2, 2018
@mitake
Copy link
Contributor Author

mitake commented Mar 2, 2018

@gaocegege rebased on the latest master, could you take a look?

@gaocegege
Copy link
Member

/lgtm

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gaocegege

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gaocegege gaocegege merged commit d7131a9 into kubeflow:master Mar 2, 2018
@mitake mitake deleted the yapf branch March 2, 2018 01:43
jimexist pushed a commit to jimexist/tf-operator that referenced this pull request Mar 7, 2018
@mitake
format the python files with yapf (kubeflow#429)
c378f12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gaocegege gaocegege gaocegege approved these changes

Assignees

@gaocegege gaocegege

Labels
approved lgtm size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mitake @gaocegege @coveralls @jimexist @k8s-ci-robot