Add proxying to front-end development server. #442
Conversation
|
Not sure @ankushagarwal or @gaocegege are JS experts. Who are the other knowleadgeable people about javascript/react? I'll open an issue to create a suitable owners file. |
|
I know little about JS but I think @jimexist may know more. |
|
If you want to know more see: https://github.com/facebook/create-react-app/blob/master/packages/react-scripts/template/README.md#proxying-api-requests-in-development Note that this doesn't affect production in any way. |
|
/lgtm |
dashboard/frontend/src/services.js
Outdated
| let host = ""; | ||
| import { getHost } from "./utils"; | ||
|
|
||
| const host = getHost(); |
There was a problem hiding this comment.
Yes, see line 6 of the same file for example.
There was a problem hiding this comment.
ok sorry missed the deleted empty string line.
|
@wbuchwalter The label do-not-merge may not work since it is not added by the bot, you could use /hold to freeze the PR and use /hold cancel to cancel it. |
|
/hold |
|
@gaocegege Ah thanks :) |
|
/hold cancel |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Jimexist, jlewi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
* dashboard: dev guide * fix dashboard + proxy issue * dashboard: move to hash router * simplify development workflow
(Dependant on #441)
Simplify the development workflow of the dashboard.
In development, all requests from the frontend (running on port 3000) will be automatically proxied to
:8080/tfjobs/where the backend dev server should be running.This avoids needing to make manual modifications to
services.jswhen developing locally.This change is