Update API to v1alpha2 #457
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/lgtm If you could split the commit to multiple, it could be better 😄 Now I have no idea which code is written and which is generated. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gaocegege The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ScorpioCPH
force-pushed
the
refactoring-api-v1alpha2
branch
from
77eb489
to
e6a9db7
Compare
|
I will merge it manually since bot can not do it. FYI, the code in v1alpha2 branch is broken after the PR |
gaocegege
pushed a commit
that referenced
this pull request
Mar 19, 2018
per this design proposal kubeflow/community#30. Update API to v1alpha2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, per this design proposal kubeflow/community#30.
Update API to v1alpha2, @jlewi @lluunn @gaocegege @DjangoPeng @ddysher PTAL, thanks!
This PR may break the CI.
This change is