Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add LabelsByIndex method to eliminate code duplication #474

Merged
merged 1 commit into from
Mar 19, 2018

Conversation

rc-zhang
Copy link
Contributor

@rc-zhang rc-zhang commented Mar 19, 2018

@gaocegege


This change is Reviewable

@gaocegege
Copy link
Member

/ok-to-test

@coveralls
Copy link

coveralls commented Mar 19, 2018

Coverage Status

Coverage increased (+0.2%) to 44.468% when pulling c9efd77 on rc-zhang:LabelsByIndex into 3a279aa on kubeflow:master.

@gaocegege
Copy link
Member

/lgtm

@rc-zhang Thanks for your contribution!

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gaocegege

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit a36b350 into kubeflow:master Mar 19, 2018
jetmuffin pushed a commit to jetmuffin/tf-operator that referenced this pull request Jul 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants