RFC: Add a new command for generating example TFjobs #509
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This command adds a new command genjob to hack/ directory. The command generates TFJobs for testing purpose. Currently the generated jobs are following the definitions of examples/tf_job.yaml and examples/tf_job_gpu.yaml. Example usage: ``` $ ./genjob --kube-config-path ~/.kube/config --nr-tfjobs 30 --use-gpu --scheduler-name tfjob ```
|
/ok-to-test I like the idea! Thanks for your contribution! |
|
/assign @gaocegege |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gaocegege The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
jetmuffin
pushed a commit
to jetmuffin/tf-operator
that referenced
this pull request
Jul 9, 2018
This command adds a new command genjob to hack/ directory. The command generates TFJobs for testing purpose. Currently the generated jobs are following the definitions of examples/tf_job.yaml and examples/tf_job_gpu.yaml. Example usage: ``` $ ./genjob --kube-config-path ~/.kube/config --nr-tfjobs 30 --use-gpu --scheduler-name tfjob ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This command adds a new command genjob to hack/ directory. The command
generates TFJobs for testing purpose. Currently the generated jobs are
following the definitions of examples/tf_job.yaml and
examples/tf_job_gpu.yaml.
Example usage (generating 30 TFJobs):
I think the command is useful for testing tf-operator and kube-batchd. The remaining major todo is adding more realistic TFJob (especially distributed examples).
This change is