fix the bug of keeping creating new pdb

[ChanYiLin]

The original code will let the controller keep creating new pdb for the job since the names are not the same.
They only have the same prefix which is GenerateName: "tf-job-pdb-".

I try to fix it by assigning the name, "tf-job-pdb-" + j.job.ObjectMeta.Name, to the pdb in order to make controller only create pdb once.

---

This change is 

[gaocegege]

Thanks for your contribution!

@k82cn Do we support owner reference based gang scheduling in kube-arbitrator? If that we could eliminate the hack about PDB.

[coveralls]

Coverage remained the same at 48.307% when pulling d1e5f12 on ChanYiLin:master into fd95c5e on kubeflow:master.

[gaocegege]

/ok-to-test

Please fix the error in Travis CI.

[ChanYiLin]

I think it's ok now.
/assign @gaocegege

[gaocegege]

I do not think so. It seems that the Travis reported that the import order is not followed. Our checker is weird and it returns some errors which is not caused by your code. Let us see if it works well 😄

[gaocegege]

I looked through the code in kube-arbitrator. It seems that the feature owner reference based gang scheduling in kube-arbitrator is not implemented, thus we keep PDB now. The code lgtm

/cc @mitake

Would you please take a look?

[k82cn]

PDB is still necessary to define the minAvailable for gang-scheduling; we need waiting the new API in upstream (we're working on that).

[gaocegege]

It seems that mitake is not around.

/lgtm

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gaocegege

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [gaocegege]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[mitake]

@gaocegege sorry for being late, this PR looks good to me.
@ChanYiLin thanks a lot for the fix!

[gaocegege]

@mitake haha No worry I just want to double check it.

[ChanYiLin]

Really thanks for your help !