Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update py_lint and py_test #569

Merged
merged 2 commits into from
May 4, 2018
Merged

Update py_lint and py_test #569

merged 2 commits into from
May 4, 2018

Conversation

ankushagarwal
Copy link

@ankushagarwal ankushagarwal commented May 3, 2018 •
edited by jlewi
Loading

kubeflow/testing#111 refactored these two tests
into two separate files

/cc @gaocegege

This change is Reviewable

Update py_lint and py_test
a6457f5 
kubeflow/testing#111 refactored these two tests
into two separate files

/cc @gaocegege
@gaocegege
Copy link
Member

/lgtm

@gaocegege
Copy link
Member 

INFO|2018-05-03T02:35:00|util.py:58| ************* Module jupyterhub_spawner
INFO|2018-05-03T02:35:00|util.py:58| R: 10, 2: Method could be a function (no-self-use)
INFO|2018-05-03T02:35:00|util.py:58| R: 29, 2: Method could be a function (no-self-use)
INFO|2018-05-03T02:35:00|util.py:58| E: 70, 0: Undefined variable 'c' (undefined-variable)
INFO|2018-05-03T02:35:00|util.py:58| E: 71, 0: Undefined variable 'c' (undefined-variable)
INFO|2018-05-03T02:35:00|util.py:58| E: 74, 0: Undefined variable 'c' (undefined-variable)
INFO|2018-05-03T02:35:00|util.py:58| E: 80, 0: Undefined variable 'c' (undefined-variable)
INFO|2018-05-03T02:35:00|util.py:58| E: 81, 0: Undefined variable 'c' (undefined-variable)
INFO|2018-05-03T02:35:00|util.py:58| E: 82, 0: Undefined variable 'c' (undefined-variable)
INFO|2018-05-03T02:35:00|util.py:58| E: 83, 0: Undefined variable 'c' (undefined-variable)
INFO|2018-05-03T02:35:00|util.py:58| E: 85, 0: Undefined variable 'c' (undefined-variable)
INFO|2018-05-03T02:35:00|util.py:58| E: 94, 0: Undefined variable 'c' (undefined-variable)
INFO|2018-05-03T02:35:00|util.py:58| E: 96, 0: Undefined variable 'c' (undefined-variable)
INFO|2018-05-03T02:35:00|util.py:58| E: 97, 0: Undefined variable 'c' (undefined-variable)
INFO|2018-05-03T02:35:00|util.py:58| E: 98, 0: Undefined variable 'c' (undefined-variable)
INFO|2018-05-03T02:35:00|util.py:58| E:104, 0: Undefined variable 'c' (undefined-variable)
INFO|2018-05-03T02:35:00|util.py:58| W:  2, 0: Unused import os (unused-import)
INFO|2018-05-03T02:35:00|util.py:58| W:  4, 0: Unused RemoteUserAuthenticator imported from jhub_remote_user_authenticator.remote_user_auth (unused-import)
INFO|2018-05-03T02:35:00|util.py:58| W:  5, 0: Unused GitHubOAuthenticator imported from oauthenticator.github (unused-import)
INFO|2018-05-03T02:35:00|util.py:58| 
INFO|2018-05-03T02:35:00|util.py:58| ------------------------------------
INFO|2018-05-03T02:35:00|util.py:58| Your code has been rated at -4.58/10

@gaocegege
Copy link
Member

I am not sure if we should run pylint on the module jupyterhub_spawner

@k8s-ci-robot k8s-ci-robot removed the lgtm label May 3, 2018
@ankushagarwal
Copy link
Author

/retest

@gaocegege
Copy link
Member

/lgtm

@gaocegege
Copy link
Member

/approve

Thanks

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gaocegege

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit bab9d9e into kubeflow:master May 4, 2018
@ankushagarwal ankushagarwal deleted the py_test branch June 6, 2018 15:09
yph152 pushed a commit to yph152/tf-operator that referenced this pull request Jun 18, 2018
Update py_lint and py_test (kubeflow#569)
fcc8073 
* Update py_lint and py_test

kubeflow/testing#111 refactored these two tests
into two separate files

/cc @gaocegege

* Ignore jupyterhub_spawner.py
jetmuffin pushed a commit to jetmuffin/tf-operator that referenced this pull request Jul 9, 2018
@k8s-ci-robot
Update py_lint and py_test (kubeflow#569)
18236a2 
* Update py_lint and py_test

kubeflow/testing#111 refactored these two tests
into two separate files

/cc @gaocegege

* Ignore jupyterhub_spawner.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gaocegege gaocegege Awaiting requested review from gaocegege

Assignees

@gaocegege gaocegege

Labels
approved lgtm size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ankushagarwal @gaocegege @k8s-ci-robot