Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing string for logging placeholder #570

Merged
merged 1 commit into from May 7, 2018
Merged

Fix missing string for logging placeholder #570

merged 1 commit into from May 7, 2018

Conversation

zachzhaozy
Copy link
Contributor

@zachzhaozy zachzhaozy commented May 7, 2018

In py/release.py, an info logging uses a placeholder, but no string matches that.

This PR completes that missing string.


This change is Reviewable

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

@zachzhaozy
Copy link
Contributor Author

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

@coveralls
Copy link

coveralls commented May 7, 2018

Coverage Status

Coverage decreased (-0.08%) to 49.782% when pulling 009cc29 on AIIFIT:fix-missing-string-for-logging-placeholder into 2a22ad4 on kubeflow:master.

@gaocegege
Copy link
Member

/ok-to-test
/lgtm

@gaocegege
Copy link
Member

/approve

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gaocegege

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 0de755c into kubeflow:master May 7, 2018
@gaocegege
Copy link
Member

@zacharyzhao
Thanks for your contribution!

@zachzhaozy zachzhaozy deleted the fix-missing-string-for-logging-placeholder branch May 7, 2018 08:38
yph152 pushed a commit to yph152/tf-operator that referenced this pull request Jun 18, 2018
jetmuffin pushed a commit to jetmuffin/tf-operator that referenced this pull request Jul 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants