.travis.yml: Fix cmd errors #592

gaocegege · 2018-05-11T06:17:47Z

Close #586

This change is

Signed-off-by: Ce Gao <gaoce@caicloud.io>

TravisBuddy · 2018-05-11T06:30:23Z

Travis tests have failed

Hey @gaocegege,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

3rd Build

gometalinter --config=linter_config.json --vendor ./...

dashboard/backend/handler/api_handler.go:224:32:warning: error return value not checked (response.WriteHeaderAndEntity(http.StatusOK, string(logs))) (errcheck)
dashboard/backend/handler/api_handler.go:232:22:warning: error return value not checked (response.WriteError(http.StatusInternalServerError, err)) (errcheck)
dashboard/backend/main.go:29:21:warning: error return value not checked (http.ListenAndServe(p, nil)) (errcheck)
test/e2e/main.go:233:21:warning: should use time.Until instead of t.Sub(time.Now()) (S1024) (gosimple)
dashboard/backend/handler/api_handler.go:130:22:warning: error return value not checked (response.WriteError(http.StatusInternalServerError, err)) (errcheck)
dashboard/backend/handler/api_handler.go:133:32:warning: error return value not checked (response.WriteHeaderAndEntity(http.StatusOK, jobs)) (errcheck)
dashboard/backend/handler/api_handler.go:208:22:warning: error return value not checked (response.WriteError(http.StatusInternalServerError, err)) (errcheck)
dashboard/backend/handler/api_handler.go:221:22:warning: error return value not checked (response.WriteError(http.StatusInternalServerError, err)) (errcheck)
dashboard/backend/handler/api_handler.go:144:23:warning: error return value not checked (response.WriteError(http.StatusNotFound, err)) (errcheck)
dashboard/backend/handler/api_handler.go:188:22:warning: error return value not checked (response.WriteError(http.StatusInternalServerError, err)) (errcheck)
dashboard/backend/handler/api_handler.go:197:32:warning: error return value not checked (response.WriteHeaderAndEntity(http.StatusCreated, j)) (errcheck)
dashboard/backend/handler/api_handler.go:235:32:warning: error return value not checked (response.WriteHeaderAndEntity(http.StatusOK, l)) (errcheck)
dashboard/backend/handler/api_handler.go:146:23:warning: error return value not checked (response.WriteError(http.StatusInternalServerError, err)) (errcheck)
dashboard/backend/handler/api_handler.go:161:22:warning: error return value not checked (response.WriteError(http.StatusInternalServerError, err)) (errcheck)
dashboard/backend/handler/api_handler.go:173:22:warning: error return value not checked (response.WriteError(http.StatusBadRequest, err)) (errcheck)
dashboard/backend/handler/api_handler.go:194:22:warning: error return value not checked (response.WriteError(http.StatusInternalServerError, err)) (errcheck)
dashboard/backend/handler/api_handler.go:165:32:warning: error return value not checked (response.WriteHeaderAndEntity(http.StatusOK, tfJobDetail)) (errcheck)
dashboard/backend/handler/api_handler.go:184:23:warning: error return value not checked (response.WriteError(http.StatusInternalServerError, nsErr)) (errcheck)

travis_time:end:20fe9770:start=1526019558699007167,finish=1526019630313553126,duration=71614545959

coveralls · 2018-05-11T06:30:52Z

Coverage decreased (-0.06%) to 49.292% when pulling fe91641 on gaocegege:fix into f0c21f8 on kubeflow:master.

Signed-off-by: Ce Gao <gaoce@caicloud.io>

TravisBuddy · 2018-05-11T06:53:51Z

Travis tests have failed

Hey @gaocegege,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

3rd Build

gometalinter --config=linter_config.json -s test --vendor ./...

dashboard/backend/handler/api_handler.go:211:32:warning: error return value not checked (response.WriteHeaderAndEntity(http.StatusCreated, j)) (errcheck)
dashboard/backend/main.go:29:21:warning: error return value not checked (http.ListenAndServe(p, nil)) (errcheck)
test/e2e/main.go:233:21:warning: should use time.Until instead of t.Sub(time.Now()) (S1024) (gosimple)
dashboard/backend/handler/api_handler.go:148:23:warning: error return value not checked (response.WriteError(http.StatusNotFound, err)) (errcheck)
dashboard/backend/handler/api_handler.go:183:22:warning: error return value not checked (response.WriteError(http.StatusBadRequest, err)) (errcheck)
dashboard/backend/handler/api_handler.go:194:23:warning: error return value not checked (response.WriteError(http.StatusInternalServerError, nsErr)) (errcheck)

travis_time:end:1556cc0a:start=1526020926703919763,finish=1526021009393747852,duration=82689828089

TravisBuddy · 2018-05-11T07:02:32Z

Travis tests have failed

Hey @gaocegege,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

2nd Build

gometalinter --config=linter_config.json -s test --vendor ./...

dashboard/backend/main.go:30::error: possible formatting directive in Fatal call (vet)
test/e2e/main.go:233:21:warning: should use time.Until instead of t.Sub(time.Now()) (S1024) (gosimple)

3rd Build

gometalinter --config=linter_config.json -s test --vendor ./...

test/e2e/main.go:233:21:warning: should use time.Until instead of t.Sub(time.Now()) (S1024) (gosimple)
dashboard/backend/main.go:30::error: Fatal call has possible formatting directive %v (vet)

travis_time:end:27c09cd5:start=1526021483529975744,finish=1526021559182983047,duration=75653007303

Signed-off-by: Ce Gao <gaoce@caicloud.io>

gaocegege · 2018-05-11T07:31:57Z

/assign @ScorpioCPH

ScorpioCPH

LGTM with some nits.

ScorpioCPH · 2018-05-11T10:58:30Z

dashboard/backend/handler/api_handler.go

 	}
 }

 func (apiHandler *APIHandler) handleDeploy(request *restful.Request, response *restful.Response) {
 	clt := apiHandler.cManager.TFJobClient
 	tfJob := new(v1alpha1.TFJob)
 	if err := request.ReadEntity(tfJob); err != nil {
-		response.WriteError(http.StatusBadRequest, err)
+		if newErr := response.WriteError(http.StatusBadRequest, err); newErr != nil {


nit: how about use err2, If there is a third error, we can use err3 :)

Signed-off-by: Ce Gao <gaoce@caicloud.io>

gaocegege · 2018-05-11T11:13:41Z

Updated PTAL @ScorpioCPH

ScorpioCPH · 2018-05-11T11:47:59Z

/lgtm
/approve

k8s-ci-robot · 2018-05-11T11:48:02Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ScorpioCPH

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [ScorpioCPH]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

* .travis.yml: Fix cmd errors Signed-off-by: Ce Gao <gaoce@caicloud.io> * dashboard: Fix Signed-off-by: Ce Gao <gaoce@caicloud.io> * backend: Fix Signed-off-by: Ce Gao <gaoce@caicloud.io> * *: Fix Signed-off-by: Ce Gao <gaoce@caicloud.io> * api: Fix err variable name Signed-off-by: Ce Gao <gaoce@caicloud.io>

.travis.yml: Fix cmd errors

974beb2

Signed-off-by: Ce Gao <gaoce@caicloud.io>

k8s-ci-robot added the do-not-merge/work-in-progress label May 11, 2018

k8s-ci-robot requested review from ankushagarwal and jimexist May 11, 2018 06:17

k8s-ci-robot added the size/S label May 11, 2018

dashboard: Fix

a1b7602

Signed-off-by: Ce Gao <gaoce@caicloud.io>

k8s-ci-robot added size/M and removed size/S labels May 11, 2018

backend: Fix

e66f71d

Signed-off-by: Ce Gao <gaoce@caicloud.io>

gaocegege added the priority/p0 label May 11, 2018

*: Fix

5a184e2

Signed-off-by: Ce Gao <gaoce@caicloud.io>

gaocegege changed the title ~~WIP: .travis.yml: Fix cmd errors~~ .travis.yml: Fix cmd errors May 11, 2018

k8s-ci-robot removed the do-not-merge/work-in-progress label May 11, 2018

k8s-ci-robot assigned ScorpioCPH May 11, 2018

gaocegege mentioned this pull request May 11, 2018

test: Fix data race problem #593

Merged

ScorpioCPH approved these changes May 11, 2018

View reviewed changes

api: Fix err variable name

fe91641

Signed-off-by: Ce Gao <gaoce@caicloud.io>

k8s-ci-robot added the lgtm label May 11, 2018

k8s-ci-robot added the approved label May 11, 2018

k8s-ci-robot merged commit 2918f08 into kubeflow:master May 11, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

.travis.yml: Fix cmd errors #592

.travis.yml: Fix cmd errors #592

gaocegege commented May 11, 2018 •

edited by jlewi

Loading

TravisBuddy commented May 11, 2018

coveralls commented May 11, 2018 •

edited

Loading

TravisBuddy commented May 11, 2018

TravisBuddy commented May 11, 2018

gaocegege commented May 11, 2018

ScorpioCPH left a comment

ScorpioCPH May 11, 2018

gaocegege May 11, 2018

gaocegege commented May 11, 2018

ScorpioCPH commented May 11, 2018

k8s-ci-robot commented May 11, 2018

.travis.yml: Fix cmd errors #592

.travis.yml: Fix cmd errors #592

Conversation

gaocegege commented May 11, 2018 • edited by jlewi Loading

TravisBuddy commented May 11, 2018

Travis tests have failed

3rd Build

coveralls commented May 11, 2018 • edited Loading

TravisBuddy commented May 11, 2018

Travis tests have failed

3rd Build

TravisBuddy commented May 11, 2018

Travis tests have failed

2nd Build

3rd Build

gaocegege commented May 11, 2018

ScorpioCPH left a comment

Choose a reason for hiding this comment

ScorpioCPH May 11, 2018

Choose a reason for hiding this comment

gaocegege May 11, 2018

Choose a reason for hiding this comment

gaocegege commented May 11, 2018

ScorpioCPH commented May 11, 2018

k8s-ci-robot commented May 11, 2018

gaocegege commented May 11, 2018 •

edited by jlewi

Loading

coveralls commented May 11, 2018 •

edited

Loading