Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tf-operator.v2 to release.py so that we build a Docker image containing the v1alph2 controller #601

Merged
merged 1 commit into from
May 22, 2018

Conversation

jlewi
Copy link
Contributor

@jlewi jlewi commented May 21, 2018

  • We need to add the tf-operator.v2 to release.py so that we can start building Docker images containing the new controller.

Fix #600

/assign @ScorpioCPH
/assign @gaocegege


This change is Reviewable

@coveralls
Copy link

coveralls commented May 21, 2018

Coverage Status

Coverage decreased (-0.1%) to 55.55% when pulling 2e36df9 on jlewi:build_v1alpha2 into 8cf2831 on kubeflow:master.

@jlewi
Copy link
Contributor Author

jlewi commented May 22, 2018

Test built the image

gcr.io/kubeflow-ci/tf_operator:kubeflow-tf-operator-presubmit-tfjob-e2e-601-b24b342-453-a5d2

@jlewi
Copy link
Contributor Author

jlewi commented May 22, 2018

Checked

gcr.io/kubeflow-ci/tf_operator:kubeflow-tf-operator-presubmit-tfjob-e2e-601-f09619b-456-cce6

Verified /opt/kubeflow/tf-operator.v2 exists.

…aining

the v1alpha2 controller.

Update the dockerfile to install the v1alpha2 operator.

Fix kubeflow#600
@gaocegege
Copy link
Member

/lgtm
/approve

Thanks! 😄

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gaocegege

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gaocegege
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot merged commit 77375ba into kubeflow:master May 22, 2018
yph152 pushed a commit to yph152/tf-operator that referenced this pull request Jun 18, 2018
…aining (kubeflow#601)

the v1alpha2 controller.

Update the dockerfile to install the v1alpha2 operator.

Fix kubeflow#600
jetmuffin pushed a commit to jetmuffin/tf-operator that referenced this pull request Jul 9, 2018
…aining (kubeflow#601)

the v1alpha2 controller.

Update the dockerfile to install the v1alpha2 operator.

Fix kubeflow#600
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants