Informer: Use unstructured #610
Conversation
Signed-off-by: Ce Gao <gaoce@caicloud.io>
Signed-off-by: Ce Gao <gaoce@caicloud.io>
Signed-off-by: Ce Gao <gaoce@caicloud.io>
|
/assign @jlewi |
|
We should add e2e test to test the feature. it is a todo task. |
| */ | ||
|
|
||
| // Note(CPH): this file is copied form k8s.io/kubernetes/pkg/controller | ||
| // We should not import the huge package k8s.io/kubernetes/pkg |
There was a problem hiding this comment.
The code is written by our own thus we use our copyright holder.
|
This is great! Thank you so much for fixing this bug! So glad we have a fix for 0.2. /lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jlewi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
FYI, this is for v1alpha2, I believe that it will also be a huge change to implement it on v1alpha1. We are relying on the typed informer heavily. |
|
/retest |
|
@gaocegege Yup; I was expecting that we would only fix this in v1alpha2; I think its perfectly fine to only fix things in the new version. |
* vendor: Update Signed-off-by: Ce Gao <gaoce@caicloud.io> * gopkg: Update Signed-off-by: Ce Gao <gaoce@caicloud.io> * controller: Use unstructured informer Signed-off-by: Ce Gao <gaoce@caicloud.io>
* vendor: Update Signed-off-by: Ce Gao <gaoce@caicloud.io> * gopkg: Update Signed-off-by: Ce Gao <gaoce@caicloud.io> * controller: Use unstructured informer Signed-off-by: Ce Gao <gaoce@caicloud.io>
Close #561
Ref #561 (comment)
This PR uses unstructured informer instead of generated typed informer to allow wrong spec.
It is a huge change, and we have to update the dep from kubernetes 1.8 to 1.9 to support the change. And the test cases also have some corresponding updates.
cec8efe is the actual changes and other commits are about vendor.
This change is