Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: Add test cases for service ref manager and control interface #615

Merged
merged 3 commits into from
Jun 1, 2018
Merged

test: Add test cases for service ref manager and control interface #615

merged 3 commits into from
Jun 1, 2018

Conversation

gaocegege
Copy link
Member

@gaocegege gaocegege commented Jun 1, 2018 •
edited by jlewi
Loading

This change is Reviewable

@gaocegege
vendor: Update
8ab169a 
Signed-off-by: Ce Gao <gaoce@caicloud.io>
@gaocegege
test: Add
a3df0b2 
Signed-off-by: Ce Gao <gaoce@caicloud.io>
@k8s-ci-robot k8s-ci-robot requested review from lluunn and vishh June 1, 2018 05:01
@coveralls
Copy link

Coverage Status

Coverage increased (+0.6%) to 56.004% when pulling a3df0b2 on gaocegege:test-new into 485d430 on kubeflow:master.

@coveralls
Copy link

coveralls commented Jun 1, 2018 •
edited
Loading

Coverage Status

Coverage increased (+1.4%) to 56.774% when pulling d275c53 on gaocegege:test-new into 485d430 on kubeflow:master.

@gaocegege
test: Add ref manager test
d275c53 
Signed-off-by: Ce Gao <gaoce@caicloud.io>
@gaocegege gaocegege changed the title WIP: test: Add test cases for service ref manager and control interface test: Add test cases for service ref manager and control interface Jun 1, 2018
@gaocegege
Copy link
Member Author

/retest

@gaocegege
Copy link
Member Author

This blocks #616 , thus merged without review.

@gaocegege
Copy link
Member Author

/approve

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gaocegege

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 924e927 into kubeflow:master Jun 1, 2018
@gaocegege gaocegege deleted the test-new branch June 1, 2018 06:58
yph152 pushed a commit to yph152/tf-operator that referenced this pull request Jun 18, 2018
@gaocegege
test: Add test cases for service ref manager and control interface (k…
3678044 
…ubeflow#615)

* vendor: Update

Signed-off-by: Ce Gao <gaoce@caicloud.io>

* test: Add

Signed-off-by: Ce Gao <gaoce@caicloud.io>

* test: Add ref manager test

Signed-off-by: Ce Gao <gaoce@caicloud.io>
jetmuffin pushed a commit to jetmuffin/tf-operator that referenced this pull request Jul 9, 2018
@gaocegege @k8s-ci-robot
test: Add test cases for service ref manager and control interface (k…
cc399b5 
…ubeflow#615)

* vendor: Update

Signed-off-by: Ce Gao <gaoce@caicloud.io>

* test: Add

Signed-off-by: Ce Gao <gaoce@caicloud.io>

* test: Add ref manager test

Signed-off-by: Ce Gao <gaoce@caicloud.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lluunn lluunn Awaiting requested review from lluunn

@vishh vishh Awaiting requested review from vishh

Assignees
No one assigned
Labels
approved lgtm size/XXL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gaocegege @coveralls @k8s-ci-robot