*: Set name for the pod tfjob.name-type-index
#636
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ce Gao <gaoce@caicloud.io>
Signed-off-by: Ce Gao <gaoce@caicloud.io>
|
/retest |
Signed-off-by: Ce Gao <gaoce@caicloud.io>
gaocegege
changed the title
tfjob.name-type-indextfjob.name-type-index
|
/assign @jlewi |
|
Thanks for the quick fix! |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jlewi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
yph152
pushed a commit
to yph152/tf-operator
that referenced
this pull request
Jun 18, 2018
* .gitignore: Ignore binary in root Signed-off-by: Ce Gao <gaoce@caicloud.io> * *: Implement pod control to use name directly Signed-off-by: Ce Gao <gaoce@caicloud.io> * pkg: Add test cases for pod_control Signed-off-by: Ce Gao <gaoce@caicloud.io>
jetmuffin
pushed a commit
to jetmuffin/tf-operator
that referenced
this pull request
Jul 9, 2018
* .gitignore: Ignore binary in root Signed-off-by: Ce Gao <gaoce@caicloud.io> * *: Implement pod control to use name directly Signed-off-by: Ce Gao <gaoce@caicloud.io> * pkg: Add test cases for pod_control Signed-off-by: Ce Gao <gaoce@caicloud.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #633
Before the PR, we use RealPodControl in Kubernetes code base to create pod with the given TFJob, and it uses the name of TFJob as the prefix of the pod created, which does not meet our need. Thus I implement the pod control on our own and remove the logic about the name. Now we set the name for the pod template and it will be used to create pods.
This change is