Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

return err if the spec area is nil after unmashal for tfjob v1alpha2 #678

Merged
merged 1 commit into from
Jun 16, 2018

Conversation

jiaxuanzhou
Copy link
Contributor

@jiaxuanzhou jiaxuanzhou commented Jun 15, 2018

this is to fix: #641
func tfJobFromUnstructured may not recognize the spec area, tfjob.Spec.TFReplicaSpecs will be nil then, this logic should be considered to be err and stop sync.


This change is Reviewable

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

@googlebot
Copy link

CLAs look good, thanks!

@coveralls
Copy link

coveralls commented Jun 15, 2018

Coverage Status

Coverage remained the same at 57.852% when pulling b6ec3e7 on jiaxuanzhou:fix into f405fb2 on kubeflow:master.

@gaocegege
Copy link
Member

Please add some comments about the code.

For example, This is to close #641

Because the check may conflict ppl.

@gaocegege
Copy link
Member

/ok-to-test

@gaocegege
Copy link
Member

/lgtm
/approve

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gaocegege

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gaocegege
Copy link
Member

I will do it for you.

Thanks for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[v1alpha2]Unable to create pod
5 participants