setup cors for redirects under iap #688

kkasravi · 2018-06-20T15:27:18Z

This change is

coveralls · 2018-06-20T15:56:30Z

Coverage decreased (-0.07%) to 56.69% when pulling 6f91650 on kkasravi:tfjobs_iap into aae8327 on kubeflow:master.

kkasravi · 2018-06-20T17:38:42Z

Hi @swiftdiaries
Update on this PR.

I don't believe this one change will solve kubeflow/kubeflow#574 since the fetch will need to have similar options set for create and other tfjob operations.

The fetch change in services.js to get the list of jobs results in a 302 and the browser does a preflight OPTIONS on the redirect location https://accounts.google.com/o/oauth2/v2/auth?login_hint=118075057959340259429&client_id=336335541993-1m7cegck4jic23263v0gplhc46f4rmmj.apps.googleusercontent.com&response_type=code&scope=openid+email&redirect_uri=https://kamkasravi.com/_gcp_gatekeeper/authenticate&state=CihodHRwczovL2thbWthc3JhdmkuY29tL3Rmam9icy9hcGkvdGZqb2IvEjBBQWgtV1puaVV5VTVrN2FFdTg5RXRiWmtMenBPY2lnUHJnOjE1Mjk1MTM3NjE3MDY

This preflight OPTIONS check to google's accounts returns a 405. I'm going to mark this PR as WIP since I'm going to try a few other things like setting nocors on both the list and create.

gaocegege · 2018-06-21T03:00:38Z

/assign @wbuchwalter @swiftdiaries

kkasravi · 2018-06-24T19:56:03Z

@swiftdiaries

When I submit a new job in the UI I see the following:

time="2018-06-24T19:40:49Z" level=info msg="EnvKubeflowNamespace not set, use default namespace" filename="app/server.go:65"
time="2018-06-24T19:40:49Z" level=info msg="[API Version: v1alpha2 Version: v0.1.0-alpha Git SHA: Not provided. Go Version: go1.10.1 Go OS/Arch: linux/amd64]" filename="app/server.go:70"
W0624 19:40:49.182867       1 client_config.go:529] Neither --kubeconfig nor --master was specified.  Using the inClusterConfig.  This might not work.
I0624 19:40:49.187303       1 leaderelection.go:174] attempting to acquire leader lease...
time="2018-06-24T19:40:49Z" level=info msg="This pod's tfjob does not exists" filename="controller.v2/controller_pod.go:309"
time="2018-06-24T19:40:49Z" level=info msg="This pod's tfjob does not exists" filename="controller.v2/controller_pod.go:309"
time="2018-06-24T19:40:49Z" level=info msg="This pod's tfjob does not exists" filename="controller.v2/controller_pod.go:309"
time="2018-06-24T19:40:49Z" level=info msg="This pod's tfjob does not exists" filename="controller.v2/controller_pod.go:309"
time="2018-06-24T19:40:49Z" level=info msg="This pod's tfjob does not exists" filename="controller.v2/controller_pod.go:309"
time="2018-06-24T19:40:49Z" level=info msg="This pod's tfjob does not exists" filename="controller.v2/controller_pod.go:309"
time="2018-06-24T19:40:49Z" level=info msg="This pod's tfjob does not exists" filename="controller.v2/controller_pod.go:309"
time="2018-06-24T19:40:49Z" level=info msg="This pod's tfjob does not exists" filename="controller.v2/controller_pod.go:309"
time="2018-06-24T19:40:49Z" level=info msg="This pod's tfjob does not exists" filename="controller.v2/controller_pod.go:309"
time="2018-06-24T19:40:49Z" level=info msg="This pod's tfjob does not exists" filename="controller.v2/controller_pod.go:309"
time="2018-06-24T19:40:49Z" level=info msg="This pod's tfjob does not exists" filename="controller.v2/controller_pod.go:309"
time="2018-06-24T19:40:49Z" level=info msg="This pod's tfjob does not exists" filename="controller.v2/controller_pod.go:309"
time="2018-06-24T19:40:49Z" level=info msg="This pod's tfjob does not exists" filename="controller.v2/controller_pod.go:309"
time="2018-06-24T19:40:49Z" level=info msg="This pod's tfjob does not exists" filename="controller.v2/controller_pod.go:309"
time="2018-06-24T19:40:49Z" level=info msg="This pod's tfjob does not exists" filename="controller.v2/controller_pod.go:309"
time="2018-06-24T19:40:49Z" level=info msg="This pod's tfjob does not exists" filename="controller.v2/controller_pod.go:309"
time="2018-06-24T19:40:49Z" level=info msg="This pod's tfjob does not exists" filename="controller.v2/controller_pod.go:309"
time="2018-06-24T19:40:49Z" level=info msg="This pod's tfjob does not exists" filename="controller.v2/controller_pod.go:309"
time="2018-06-24T19:40:49Z" level=info msg="This pod's tfjob does not exists" filename="controller.v2/controller_pod.go:309"
time="2018-06-24T19:40:49Z" level=info msg="This pod's tfjob does not exists" filename="controller.v2/controller_pod.go:309"
time="2018-06-24T19:40:49Z" level=info msg="This pod's tfjob does not exists" filename="controller.v2/controller_pod.go:309"
time="2018-06-24T19:40:49Z" level=info msg="This pod's tfjob does not exists" filename="controller.v2/controller_pod.go:309"
time="2018-06-24T19:40:49Z" level=info msg="This pod's tfjob does not exists" filename="controller.v2/controller_pod.go:309"
time="2018-06-24T19:40:49Z" level=info msg="This pod's tfjob does not exists" filename="controller.v2/controller_pod.go:309"
time="2018-06-24T19:40:49Z" level=info msg="This pod's tfjob does not exists" filename="controller.v2/controller_pod.go:309"
time="2018-06-24T19:40:49Z" level=info msg="This pod's tfjob does not exists" filename="controller.v2/controller_pod.go:309"
time="2018-06-24T19:40:49Z" level=info msg="This pod's tfjob does not exists" filename="controller.v2/controller_pod.go:309"
E0624 19:41:29.473920       1 event.go:260] Could not construct reference to: '&v1.Endpoints{TypeMeta:v1.TypeMeta{Kind:"", APIVersion:""}, ObjectMeta:v1.ObjectMeta{Name:"tf-operator", GenerateName:"", Namespace:"default", SelfLink:"/api/v1/namespaces/default/endpoints/tf-operator", UID:"7ccfef35-76f4-11e8-879b-42010a8a01ab", ResourceVersion:"326085", Generation:0, CreationTimestamp:v1.Time{Time:time.Time{wall:0x0, ext:63665362107, loc:(*time.Location)(0x1aded60)}}, DeletionTimestamp:(*v1.Time)(nil), DeletionGracePeriodSeconds:(*int64)(nil), Labels:map[string]string(nil), Annotations:map[string]string{"control-plane.alpha.kubernetes.io/leader":"{\"holderIdentity\":\"tf-job-operator-v1alpha2-5bfdc6b65d-sdqg4\",\"leaseDurationSeconds\":15,\"acquireTime\":\"2018-06-24T19:41:29Z\",\"renewTime\":\"2018-06-24T19:41:29Z\",\"leaderTransitions\":5}"}, OwnerReferences:[]v1.OwnerReference(nil), Initializers:(*v1.Initializers)(nil), Finalizers:[]string(nil), ClusterName:""}, Subsets:[]v1.EndpointSubset(nil)}' due to: 'no kind is registered for the type v1.Endpoints'. Will not report event: 'Normal' 'LeaderElection' 'tf-job-operator-v1alpha2-5bfdc6b65d-sdqg4 became leader'
I0624 19:41:29.474470       1 leaderelection.go:184] successfully acquired lease default/tf-operator
time="2018-06-24T19:41:29Z" level=info msg="Starting TFJob controller" filename="controller.v2/controller.go:251"
time="2018-06-24T19:41:29Z" level=info msg="Waiting for informer caches to sync" filename="controller.v2/controller.go:254"
time="2018-06-24T19:41:29Z" level=info msg="Starting 1 workers" filename="controller.v2/controller.go:267"
time="2018-06-24T19:41:29Z" level=info msg="Started workers" filename="controller.v2/controller.go:273"

It doesn't look like it's not getting the namespace. Do I need to set that in an environment variable in the Create job form?

kkasravi · 2018-06-26T11:51:21Z

@swiftdiaries I'm going to open an issue on the above error since it's separate from the IAP work

kkasravi · 2018-06-26T12:44:22Z

Blocked by #696
PR for 696 is available #1084

kkasravi · 2018-06-30T01:33:24Z

/retest

jlewi · 2018-07-20T06:25:13Z

@kkasravi Any update on this ?
Tests passed; do you want to just rebase this?

/assign jlewi

kkasravi · 2018-07-20T13:15:11Z

/retest

jlewi · 2018-07-20T14:36:16Z

/lgtm
/approve

@kkasravi Thank you so much for fixing this!

k8s-ci-robot · 2018-07-20T14:36:21Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jlewi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~dashboard/OWNERS~~ [jlewi]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

setup cors for redirects under iap

284d376

k8s-ci-robot requested review from mitake and swiftdiaries June 20, 2018 15:27

k8s-ci-robot added the size/S label Jun 20, 2018

kkasravi mentioned this pull request Jun 20, 2018

TFJobs UI doesn't work behind IAP; React APP needs support IAP? kubeflow/kubeflow#574

Closed

/wip

2e876b4

kkasravi mentioned this pull request Jun 20, 2018

Cross-Origin Resource Sharing with TF Jobs Dashboard kubeflow/kubeflow#1046

Closed

k8s-ci-robot assigned swiftdiaries and wbuchwalter Jun 21, 2018

added x-goog email header to backend and cors to frontend

f4f1b9a

kkasravi mentioned this pull request Jun 23, 2018

TFJobs UI doesn't work behind IAP kubeflow/kubeflow#1073

Merged

Kam D Kasravi added 6 commits June 24, 2018 06:39

Merge remote-tracking branch 'upstream/master' into tfjobs_iap

b6c16a9

add cors to tfjobs create so the credentials are included

2b97c74

fix for myheaders.append

9a50641

double parans on addheaders

3f28012

error on myheaders.append

3a5b254

use set instead of append

1b33543

use cors for all fetch calls

e368628

k8s-ci-robot added size/M and removed size/S labels Jun 29, 2018

k8s-ci-robot assigned jlewi Jul 20, 2018

Merge remote-tracking branch 'upstream/master' into tfjobs_iap

6f91650

k8s-ci-robot added the lgtm label Jul 20, 2018

k8s-ci-robot added the approved label Jul 20, 2018

k8s-ci-robot merged commit b0e6da5 into kubeflow:master Jul 20, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

setup cors for redirects under iap #688

setup cors for redirects under iap #688

kkasravi commented Jun 20, 2018 •

edited by jlewi

Loading

coveralls commented Jun 20, 2018 •

edited

Loading

kkasravi commented Jun 20, 2018

gaocegege commented Jun 21, 2018

kkasravi commented Jun 24, 2018

kkasravi commented Jun 26, 2018

kkasravi commented Jun 26, 2018

kkasravi commented Jun 30, 2018

jlewi commented Jul 20, 2018

kkasravi commented Jul 20, 2018

jlewi commented Jul 20, 2018

k8s-ci-robot commented Jul 20, 2018

setup cors for redirects under iap #688

setup cors for redirects under iap #688

Conversation

kkasravi commented Jun 20, 2018 • edited by jlewi Loading

coveralls commented Jun 20, 2018 • edited Loading

kkasravi commented Jun 20, 2018

gaocegege commented Jun 21, 2018

kkasravi commented Jun 24, 2018

kkasravi commented Jun 26, 2018

kkasravi commented Jun 26, 2018

kkasravi commented Jun 30, 2018

jlewi commented Jul 20, 2018

kkasravi commented Jul 20, 2018

jlewi commented Jul 20, 2018

k8s-ci-robot commented Jul 20, 2018

kkasravi commented Jun 20, 2018 •

edited by jlewi

Loading

coveralls commented Jun 20, 2018 •

edited

Loading